Visitar URL original
xds: fix xdsClient resource not exist for invalid resource, fix xdsServerWrapper start on resource not exist by YifeiZhuang · Pull Request #8660 · grpc/grpc-java · GitHub
Skip to content

xds: fix xdsClient resource not exist for invalid resource, fix xdsServerWrapper start on resource not exist - #8660

Merged
YifeiZhuang merged 6 commits into
grpc:masterfrom
YifeiZhuang:fix-xds-server-start
Nov 8, 2021
Merged

YifeiZhuang merged 6 commits into
grpc:masterfrom
YifeiZhuang:fix-xds-server-start

Conversation

@YifeiZhuang

@YifeiZhuang YifeiZhuang commented Nov 4, 2021 •

Copy link
Copy Markdown
Member

@ejona86 ejona86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by mini-review

@dapengzhang0 dapengzhang0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YifeiZhuang
YifeiZhuang merged commit 0b0079c into grpc:master Nov 8, 2021
@YifeiZhuang
YifeiZhuang deleted the fix-xds-server-start branch November 11, 2021 00:10
YifeiZhuang added a commit to YifeiZhuang/grpc-java that referenced this pull request Nov 11, 2021
…rverWrapper start on resource not exist (grpc#8660)

Fix bugs:
1. Invalid resource at xdsClient, the watcher should have been delivered an error instead of resource not found.
2. If the resource is properly determined to not exist, it shouldn't cause start() to fail. From A36 xDS for Servers:
"XdsServer's start must not fail due to transient xDS issues, like missing xDS configuration from the xDS server."
YifeiZhuang added a commit that referenced this pull request Nov 11, 2021
…rverWrapper start on resource not exist (1.42.x backport) (#8690)

* xds: remove filter chain uuid name generator (#8663)

Generating a uuid in filterChain breaks the de-duplication detection which causes XdsServer to cycle connections, so removing it.
An empty name is now allowed. The name is currently only used for debug purpose.

* xds: fix xdsClient resource not exist for invalid resource, fix xdsServerWrapper start on resource not exist (#8660)

Fix bugs:
1. Invalid resource at xdsClient, the watcher should have been delivered an error instead of resource not found.
2. If the resource is properly determined to not exist, it shouldn't cause start() to fail. From A36 xDS for Servers:
"XdsServer's start must not fail due to transient xDS issues, like missing xDS configuration from the xDS server."
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants