devpi-client hook broken #596

Activity

1. fschulze commented on Sep 12, 2022

   

   fschulze

   on Sep 12, 2022

   Author

   More actions

   It can more easily be triggered by devpi login username.
2. jaraco commented on Sep 17, 2022

   

   jaraco

   on Sep 17, 2022

   Owner

   More actions

   I'm slightly surprised that the argument spec isn't present, because ContextDecorator uses functools.wraps.
3. jaraco commented on Sep 17, 2022

   

   jaraco

   on Sep 17, 2022

   Owner

   More actions

   It looks like inspect.getfullargspec shows the raw args, but inspect.signature resolves the wrapping.

   >>> inspect.getfullargspec(cl.devpiclient_get_password)
   FullArgSpec(args=[], varargs='args', varkw='kwds', defaults=None, kwonlyargs=[], kwonlydefaults=None, annotations={})
   >>> inspect.signature(cl.devpiclient_get_password)
   <Signature (url, username)>
   
4. jaraco commented on Sep 17, 2022

   

   jaraco

   on Sep 17, 2022

   Owner

   More actions

   Docs say that getfullargspec is discouraged and signature should be used:

   Note that signature() and Signature Object provide the recommended API for callable introspection, and support additional behaviours (like positional-only arguments) that are sometimes encountered in extension module APIs. This function is retained primarily for use in code that needs to maintain compatibility with the Python 2 inspect module API.
5. jaraco commented on Sep 17, 2022

   

   jaraco

   on Sep 17, 2022

   Owner

   More actions

   Oh, the issue is known (pytest-dev/pluggy#358) and already linked to #582.
6. jaraco

   added 2 commits that reference this issue on Sep 17, 2022

   Add test to ensure varnames are calculated correctly. Ref #596.

   845e739

   Add workaround for pytest-dev/pluggy#358. Fixes #596.

   1dc13e5
7. jaraco

   closed this as completedin #598on Sep 17, 2022
8. jaraco commented on Sep 17, 2022

   

   jaraco

   on Sep 17, 2022

   Owner

   More actions

   v23.9.3 provides a workaround, but the core issue should be fixed upstream in pluggy.

   🎉React with 🎉1Reacted by Florian Schulze