Sandbox::https://togithub.com/protocolbuffers/protobuf/issues/8339

shadchin · 2021-02-24T00:48:01Z

"Old" buffer API will removed in Python 3.10. This is also fix #7930.

google-cla · 2021-02-24T00:48:05Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

shadchin · 2021-03-02T00:46:35Z

Can anyone watch this PR?

"Old" buffer API will removed in Python 3.10. This is also fix protocolbuffers#7930.

shadchin · 2021-03-02T22:14:58Z

I fixed warning with deprecation PyEval_CallObject for Python 3.9

@acozzette Can you rerun tests, please?

shadchin · 2021-03-02T23:23:39Z

Free bonus from switching on "new" buffer API:

add support memoryview for Python 2.7

@acozzette It looks like another restart is needed :)

shadchin · 2021-03-03T15:07:10Z

@acozzette, I don't have access for Kokoro build failed.

Could you, please, help me to understand failure reasons?

acozzette · 2021-03-03T19:00:31Z

Here is the error message and the last few log lines before it:

py27-cpp run-test: commands[1] | python setup.py -q build --cpp_implementation --warnings_as_errors --compile_static_extension
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
In file included from /tmp/protobuf/protobuf/python/.tox/py27-cpp/include/python2.7/Python.h:8,
                 from google/protobuf/pyext/descriptor_pool.cc:35:
/tmp/protobuf/protobuf/python/.tox/py27-cpp/include/python2.7/pyconfig.h:1223: error: "_POSIX_C_SOURCE" redefined [-Werror]
 #define _POSIX_C_SOURCE 200112L

In file included from /usr/include/x86_64-linux-gnu/c++/8/bits/os_defines.h:39,
                 from /usr/include/x86_64-linux-gnu/c++/8/bits/c++config.h:508,
                 from /usr/include/c++/8/type_traits:38,
                 from /usr/include/c++/8/unordered_map:38,
                 from google/protobuf/pyext/descriptor_pool.cc:33:
/usr/include/features.h:265: note: this is the location of the previous definition
 # define _POSIX_C_SOURCE 200809L

In file included from /tmp/protobuf/protobuf/python/.tox/py27-cpp/include/python2.7/Python.h:8,
                 from google/protobuf/pyext/descriptor_pool.cc:35:
/tmp/protobuf/protobuf/python/.tox/py27-cpp/include/python2.7/pyconfig.h:1245: error: "_XOPEN_SOURCE" redefined [-Werror]
 #define _XOPEN_SOURCE 600

In file included from /usr/include/x86_64-linux-gnu/c++/8/bits/os_defines.h:39,
                 from /usr/include/x86_64-linux-gnu/c++/8/bits/c++config.h:508,
                 from /usr/include/c++/8/type_traits:38,
                 from /usr/include/c++/8/unordered_map:38,
                 from google/protobuf/pyext/descriptor_pool.cc:33:
/usr/include/features.h:202: note: this is the location of the previous definition
 # define _XOPEN_SOURCE 700

cc1plus: all warnings being treated as errors
error: command 'gcc' failed with exit status 1
ERROR: InvocationError for command /tmp/protobuf/protobuf/python/.tox/py27-cpp/bin/python setup.py -q build --cpp_implementation --warnings_as_errors --compile_static_extension (exited with code 1)

shadchin · 2021-03-04T00:21:49Z

These errors are not related to the change in this PR. It looks like something has changed in the build since October 1, 2020 #7927

I removed --warnings_as_errors for Python 2.7

@acozzette Can you rerun tests, please?

google-cla Bot added the cla: no label Feb 24, 2021

shadchin force-pushed the fix_python_3_10 branch from b1981b6 to 1f8f5cf Compare February 24, 2021 01:03

google-cla Bot added cla: yes and removed cla: no labels Feb 24, 2021

shadchin changed the title ~~Switch on "new" buffer API.~~ Switch on "new" buffer API Feb 25, 2021

acozzette requested review from anandolee and dlj-NaN March 2, 2021 00:47

acozzette added release notes: yes python labels Mar 2, 2021

protobuf-kokoro removed the kokoro:run label Mar 2, 2021

shadchin added 2 commits March 3, 2021 01:08

Switch on "new" buffer API.

0a3bcf1

"Old" buffer API will removed in Python 3.10. This is also fix protocolbuffers#7930.

Switch on PyObject_Call

01cdbd4

shadchin force-pushed the fix_python_3_10 branch from 1f8f5cf to 01cdbd4 Compare March 2, 2021 22:08

acozzette added the kokoro:run label Mar 2, 2021

protobuf-kokoro removed the kokoro:run label Mar 2, 2021

Fix tests for Python 2.7

04b50d1

acozzette added the kokoro:run label Mar 2, 2021

protobuf-kokoro removed the kokoro:run label Mar 2, 2021

Returned --warnings_as_errors for Python 2.7

a3bc1f1

dlj-NaN approved these changes Mar 4, 2021

View reviewed changes

acozzette added the kokoro:run label Mar 4, 2021

protobuf-kokoro removed the kokoro:run label Mar 4, 2021

dlj-NaN added kokoro:run and removed kokoro:run labels Mar 4, 2021

dlj-NaN merged commit 87dd07b into protocolbuffers:master Mar 4, 2021

shadchin deleted the fix_python_3_10 branch March 5, 2021 03:39

Navigation Menu

Repository navigation

Switch on "new" buffer API - #8339

Switch on "new" buffer API#8339
dlj-NaN merged 4 commits into
protocolbuffers:masterfrom
shadchin:fix_python_3_10

shadchin commented Feb 24, 2021

Uh oh!

google-cla Bot commented Feb 24, 2021

Uh oh!

shadchin commented Mar 2, 2021

Uh oh!

shadchin commented Mar 2, 2021

Uh oh!

shadchin commented Mar 2, 2021

Uh oh!

shadchin commented Mar 3, 2021

Uh oh!

acozzette commented Mar 3, 2021

Uh oh!

shadchin commented Mar 4, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

shadchin commented Feb 24, 2021

Uh oh!

google-cla Bot commented Feb 24, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

shadchin commented Mar 2, 2021

Uh oh!

shadchin commented Mar 2, 2021

Uh oh!

shadchin commented Mar 2, 2021

Uh oh!

shadchin commented Mar 3, 2021

Uh oh!

acozzette commented Mar 3, 2021

Uh oh!

shadchin commented Mar 4, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants