Visitar URL original
fix: from_string method of blob and bucket class by HemangChothani · Pull Request #290 · googleapis/python-storage · GitHub
Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: from_string method of blob and bucket class - #290

Merged
gcf-merge-on-green[bot] merged 7 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_286
Nov 11, 2020
Merged

fix: from_string method of blob and bucket class#290
gcf-merge-on-green[bot] merged 7 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_286

Conversation

@HemangChothani

@HemangChothani HemangChothani commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Fixes #286

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2020
tseaver
tseaver suggested changes Oct 8, 2020
View reviewed changes

@tseaver tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than changing the signature of Blob.from_string, the fix should be to change Blob._do_multipart_upload (and likewise Blob._initiate_resumable_upload) to use the passed-in client. The caller (Blob._do_upload) should likewise call self._require_client to use its own _client attribute as a fallback for when no explicit client is passed in.

Comment thread google/cloud/storage/blob.py Resolved
tseaver
tseaver suggested changes Oct 9, 2020
View reviewed changes
Comment thread google/cloud/storage/client.py Resolved
Comment thread tests/unit/test_blob.py Resolved
@HemangChothani

HemangChothani commented Oct 29, 2020

Copy link
Copy Markdown
Contributor Author

@tseaver PTAL!

@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Nov 11, 2020
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit d457ce3 into googleapis:master Nov 11, 2020
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 11, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
fix: from_string method of blob and bucket class (googleapis#290)
a73e91e 
Fixes googleapis#286
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
fix: from_string method of blob and bucket class (googleapis#290)
3ae3a06 
Fixes googleapis#286
@release-please release-please Bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@frankyn frankyn Awaiting requested review from frankyn
1 more reviewer
@tseaver tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Blob upload_from_string AttributeError when using client argument

2 participants

@HemangChothani @tseaver