Visitar URL original
fix: add SAML challenge to reauth by arithmetic1728 · Pull Request #819 · googleapis/google-auth-library-python · GitHub
Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: add SAML challenge to reauth - #819

Merged
arithmetic1728 merged 13 commits into
mainfrom
reauth
Sep 7, 2021
Merged

fix: add SAML challenge to reauth#819
arithmetic1728 merged 13 commits into
mainfrom
reauth

Conversation

@arithmetic1728

@arithmetic1728 arithmetic1728 commented Jul 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR:

(1) re-add SAML challenge to reauth. It throws exception to fail early, and the exception is used by gcloud to instruct the users to do gcloud auth login. Without it, SAML users have to enter password 5 times then fail.

(2) when creating user credential, read rapt_token field from the json file if exists.

(3) disable reauth flow for user credentials and add a new enable_reauth_refresh flag to user credentials constructor.

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2021
@arithmetic1728
arithmetic1728 marked this pull request as ready for review July 29, 2021 19:27
@arithmetic1728
arithmetic1728 requested a review from silvolu as a code owner July 29, 2021 19:27
@arithmetic1728
arithmetic1728 requested review from a team, busunkim96 and liuchaoren July 29, 2021 19:27
liuchaoren
liuchaoren reviewed Jul 30, 2021
View reviewed changes
Comment thread google/auth/exceptions.py Resolved
liuchaoren
liuchaoren reviewed Jul 30, 2021
View reviewed changes
Comment thread google/oauth2/_reauth_async.py Resolved
liuchaoren
liuchaoren reviewed Jul 30, 2021
View reviewed changes
Comment thread google/oauth2/challenges.py Resolved
liuchaoren
liuchaoren reviewed Jul 30, 2021
View reviewed changes
Comment thread google/oauth2/challenges.py Resolved
liuchaoren
liuchaoren reviewed Jul 30, 2021
View reviewed changes
Comment thread google/oauth2/challenges.py Resolved
liuchaoren
liuchaoren reviewed Jul 30, 2021
View reviewed changes
Comment thread google/oauth2/credentials.py Resolved
Comment thread google/oauth2/reauth.py Resolved
silvolu
silvolu suggested changes Aug 6, 2021
View reviewed changes
Comment thread google/oauth2/_reauth_async.py Resolved
Comment thread google/oauth2/challenges.py Resolved
Comment thread google/oauth2/reauth.py Resolved
Comment thread google/oauth2/reauth.py Resolved
liuchaoren
liuchaoren approved these changes Aug 12, 2021
View reviewed changes
Comment thread google/oauth2/reauth.py Resolved
liuchaoren
liuchaoren approved these changes Aug 12, 2021
View reviewed changes
Comment thread google/oauth2/challenges.py Resolved
@arithmetic1728
arithmetic1728 merged commit 13aed5f into main Sep 7, 2021
@arithmetic1728
arithmetic1728 deleted the reauth branch September 7, 2021 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96
2 more reviewers
@liuchaoren liuchaoren liuchaoren approved these changes
@silvolu silvolu silvolu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arithmetic1728 @silvolu @liuchaoren @tseaver