Visitar URL original
Add class static blocks to `preset-env`'s `shippedProposals` by nicolo-ribaudo · Pull Request #13114 · babel/babel · GitHub
Skip to content

Add class static blocks to preset-env's shippedProposals - #13114

Merged
nicolo-ribaudo merged 3 commits into
babel:feat-7.14.0/preset-envfrom
nicolo-ribaudo:shipped-proposal-static-block
Apr 16, 2021
Merged

Add class static blocks to preset-env's shippedProposals#13114
nicolo-ribaudo merged 3 commits into
babel:feat-7.14.0/preset-envfrom
nicolo-ribaudo:shipped-proposal-static-block

Conversation

@nicolo-ribaudo

@nicolo-ribaudo nicolo-ribaudo commented Apr 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

cc @rbuckton (just fyi) this means that Babel users can now use it with @babel/preset-env without needing to manually install a separate plugin.

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: preset-env Spec: Class Static Block labels Apr 7, 2021
@babel-bot

babel-bot commented Apr 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45121/

@codesandbox-ci

codesandbox-ci Bot commented Apr 7, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6481085:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

nicolo-ribaudo
nicolo-ribaudo commented Apr 7, 2021
View reviewed changes
Comment thread packages/babel-preset-env/src/filter-items.js
@nicolo-ribaudo nicolo-ribaudo added this to the v7.14.0 milestone Apr 7, 2021
@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Apr 8, 2021
@nicolo-ribaudo
nicolo-ribaudo force-pushed the shipped-proposal-static-block branch from b0409b3 to 96b0184 Compare April 8, 2021 09:36
@JLHwung

JLHwung commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

We should also add private brand checks to shippedProposals: https://chromestatus.com/feature/5006138707804160

jridgewell
jridgewell approved these changes Apr 9, 2021
View reviewed changes

@jridgewell jridgewell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At what stage do we usually add to shipped?

@nicolo-ribaudo

nicolo-ribaudo commented Apr 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

When at least one browser ships it unflagged. Chrome 91 is still in dev which is quite experimental, but it will be beta in two weeks (which I think will be more or less when we'll publish 7.14.0).

@nicolo-ribaudo
nicolo-ribaudo changed the base branch from main to feat-7.14.0/preset-env April 9, 2021 17:04
@nicolo-ribaudo
nicolo-ribaudo merged commit 64b3d9e into babel:feat-7.14.0/preset-env Apr 16, 2021
@nicolo-ribaudo
nicolo-ribaudo deleted the shipped-proposal-static-block branch April 16, 2021 17:46
@nicolo-ribaudo

nicolo-ribaudo commented Apr 16, 2021

Copy link
Copy Markdown
Member Author

Merged to feat-7.14.0/preset-env

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 16, 2021
Merged
5 tasks done
nicolo-ribaudo added a commit that referenced this pull request Apr 16, 2021
@nicolo-ribaudo
Add class static blocks to preset-env's shippedProposals (#13114)
a56dd89
nicolo-ribaudo added a commit that referenced this pull request Apr 16, 2021
@nicolo-ribaudo
Add class static blocks to preset-env's shippedProposals (#13114)
0c58c2e
nicolo-ribaudo added a commit that referenced this pull request Apr 19, 2021
@nicolo-ribaudo
Add class static blocks to preset-env's shippedProposals (#13114)
838211b
nicolo-ribaudo added a commit that referenced this pull request Apr 20, 2021
@nicolo-ribaudo
Add class static blocks to preset-env's shippedProposals (#13114)
d7d910a
nicolo-ribaudo added a commit that referenced this pull request Apr 21, 2021
@nicolo-ribaudo
Add class static blocks to preset-env's shippedProposals (#13114)
0da175b
nicolo-ribaudo added a commit that referenced this pull request Apr 28, 2021
@nicolo-ribaudo
Add class static blocks to preset-env's shippedProposals (#13114)
3c2b98f
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 17, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jridgewell jridgewell jridgewell approved these changes
@hzoo hzoo hzoo approved these changes
@JLHwung JLHwung JLHwung approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Class Static Block

Projects

None yet

Milestone

v7.14.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolo-ribaudo @babel-bot @JLHwung @jridgewell @hzoo