Visitar URL original
fix destructuring of empty string by lala7573 路 Pull Request #13444 路 babel/babel 路 GitHub
Skip to content

fix destructuring of empty string - #13444

Merged
nicolo-ribaudo merged 4 commits into
babel:mainfrom
lala7573:fix-13421
Jun 14, 2021
Merged

fix destructuring of empty string#13444
nicolo-ribaudo merged 4 commits into
babel:mainfrom
lala7573:fix-13421

Conversation

@lala7573

@lala7573 lala7573 commented Jun 9, 2021 •
edited by gitpod-io Bot
Loading

Copy link
Copy Markdown
Contributor
Q 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 A
Fixed Issues? Fixes #13421
Patch: Bug Fix? 馃憤
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? 馃憤
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 馃悰 A type of pull request used for our changelog categories label Jun 9, 2021
nicolo-ribaudo
nicolo-ribaudo reviewed Jun 9, 2021
View reviewed changes
Comment thread packages/babel-plugin-transform-destructuring/test/fixtures/destructuring/empty-string/exec.js Outdated
@codesandbox-ci

codesandbox-ci Bot commented Jun 9, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c54ef3:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

jridgewell
jridgewell approved these changes Jun 9, 2021
View reviewed changes
Comment thread packages/babel-helpers/src/helpers.js Outdated
@babel-bot

babel-bot commented Jun 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46827/

@nicolo-ribaudo

nicolo-ribaudo commented Jun 10, 2021

Copy link
Copy Markdown
Member

Can you run OVERWRITE=true yarn jest to update the failing test?

@nicolo-ribaudo

nicolo-ribaudo commented Jun 10, 2021

Copy link
Copy Markdown
Member

It seems like there are some unrelated changes caused by outdated dependencies 馃

If CI fails, try running yarn and then re-generate the fixtures again.

@lala7573

lala7573 commented Jun 12, 2021

Copy link
Copy Markdown
Contributor Author

@nicolo-ribaudo
I removed node_modules and reinstalled using yarn and then re-generate the fixtures. And the ci tests seem almost done.
Is there anything that I should have to do with this pr? Please tell me!!
Thank you for your kind guides and feedbacks.

@nicolo-ribaudo

nicolo-ribaudo commented Jun 14, 2021

Copy link
Copy Markdown
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo changed the title fix destructuring empty string fix destructuring of empty string Jun 14, 2021
@nicolo-ribaudo
nicolo-ribaudo merged commit 950d351 into babel:main Jun 14, 2021
@lala7573
lala7573 deleted the fix-13421 branch June 15, 2021 10:14
@sync-by-unito sync-by-unito Bot mentioned this pull request Jun 15, 2021
Closed
@sync-by-unito sync-by-unito Bot mentioned this pull request Jun 22, 2021
Closed
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 15, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments
@jridgewell jridgewell jridgewell approved these changes
@fedeci fedeci fedeci approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 馃悰 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Destructuring empty string to array causes runtime error

5 participants

@lala7573 @babel-bot @nicolo-ribaudo @jridgewell @fedeci