Repository navigation
minor improvement to gulp generate-runtime-helpers error message - #13522
Merged
Merged
Conversation
If you had some garbage in packages/babel-runtime-helpers/src/helpers/,
gulp generate-runtime-helpers would blow up with an unhelpful message:
TypeError: Cannot read property 'groups' of null
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47153/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit daa02c8:
|
JLHwung
approved these changes
Jul 2, 2021
JLHwung
added
the
PR: Internal 🏠
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jul 30, 2021
…el#13522) * improve gulp generate-runtime-helpers error message If you had some garbage in packages/babel-runtime-helpers/src/helpers/, gulp generate-runtime-helpers would blow up with an unhelpful message: TypeError: Cannot read property 'groups' of null * ignore files starting with a dot when generating runtime helpers
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate-helpers.jsfailed with an unhelpfulTypeErrorif it couldn't find aminVersionin some file undersrc/helpers/. I had some (hidden) vim swap files in there and it was quite baffling. So after adding a more informative message I also made it ignore dotfiles.