Repository navigation
Revert "Fix missing requires of i18n/core_ext/hash" - #602
Merged
Merged
Conversation
|
@radar are you planning to release this as $ gem install i18n
Fetching i18n-1.9.0.gem
Successfully installed i18n-1.9.0
1 gem installed
$ irb
001 > require 'i18n'
=> true
002 > I18n::Backend::Chain
<.../ruby/3.0.0/rubygems/core_ext/kernel_require.rb>:160:in `require': cannot load such file -- i18n/core_ext/hash (LoadError)I noticed b/c we tried to update i18n in our app and it caused the above exception. |
Contributor
|
An update would be highly appreciated, as I can not build (and test) this when attempting to create the package on Arch Linux. |
Contributor
|
Out of general curiosity: How did this not make all tests in CI fail since August and more specifically when that commit was added via pull request in #574? 🤔 |
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jan 27, 2022
Add upstream patch to remove broken imports: ruby-i18n/i18n#602 Add upstream patch to remove unused pry gem: ruby-i18n/i18n#608 Simplify quoting in file. Use check() to run tests (finally). Various style fixes and simplifications. git-svn-id: file:///srv/repos/svn-community/svn@1117463 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jan 27, 2022
Add upstream patch to remove broken imports: ruby-i18n/i18n#602 Add upstream patch to remove unused pry gem: ruby-i18n/i18n#608 Simplify quoting in file. Use check() to run tests (finally). Various style fixes and simplifications. git-svn-id: file:///srv/repos/svn-community/svn@1117463 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Collaborator
Author
|
@dvzrv Please be aware that I am the sole maintainer and located in Australia. When you posted your comment, the local time was 6:27am. The PR you're pointing to was created in August, but was only merged ~22hrs ago. @jordan-brough I can yank 1.9.0 so that it's uninstallable, after I release a 1.9.1. |
Contributor
Ah good point! Didn't notice that :) |
tachyons
added a commit
to CircuitVerse/CircuitVerse
that referenced
this pull request
Jan 28, 2022
cbliard
referenced
this pull request
in opf/openproject
Jan 28, 2022
1.9.0 was yanked and cannot be downloaded anymore. See https://github.com/ruby-i18n/i18n/pull/602\#issuecomment-1023629568
cbliard
referenced
this pull request
in opf/openproject
Jan 28, 2022
1.9.0 was yanked and cannot be downloaded anymore. See https://github.com/ruby-i18n/i18n/pull/602\#issuecomment-1023629568
|
How is #574 supposed to be resolved in environments that exhibit this problem. E.g. in one of our |
Collaborator
Author
|
Refinements were removed here: #573
Either change your code to remove the reference to refinements, or use a version of i18n that still has them.
…On 31 Jan 2022, 02:38 +1100, David Raison ***@***.***>, wrote:
How is #574 supposed to be resolved in environments that exhibit this problem. E.g. in one of our decidim installations, we do see the same problem:
***@***.***:~/decidim$ bundle exec rails db:migrate --trace
** Invoke db:migrate (first_time)
** Invoke db:load_config (first_time) ** Invoke environment (first_time)
** Execute environment rails aborted!
NameError: uninitialized constant I18n::HashRefinements /home/decidim/.rbenv/versions/2.7.5/lib/ruby/gems/2.7.0/bundler/gems/decidim-module-term_customizer-0e823f4f768f/li
b/decidim/term_customizer/i18n_backend.rb:9:in `<class:I18nBackend>'
[…]
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Collaborator
Author
|
I’m out and about now, just on my phone. I’ll need to double check this as #573 has other issues that are reported against it. Seems like I might be missing something here on my little screen.
…On 31 Jan 2022, 02:38 +1100, David Raison ***@***.***>, wrote:
How is #574 supposed to be resolved in environments that exhibit this problem. E.g. in one of our decidim installations, we do see the same problem:
***@***.***:~/decidim$ bundle exec rails db:migrate --trace
** Invoke db:migrate (first_time)
** Invoke db:load_config (first_time) ** Invoke environment (first_time)
** Execute environment rails aborted!
NameError: uninitialized constant I18n::HashRefinements /home/decidim/.rbenv/versions/2.7.5/lib/ruby/gems/2.7.0/bundler/gems/decidim-module-term_customizer-0e823f4f768f/li
b/decidim/term_customizer/i18n_backend.rb:9:in `<class:I18nBackend>'
[…]
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
thibaudgg
added a commit
to electric-feel/i18n-backend-side_by_side
that referenced
this pull request
Mar 20, 2022
This upgrades the logic to support the I18n 1.10.0 release, that was broking with issue like: ``` LoadError: cannot load such file -- i18n/core_ext/hash ``` or ``` NameError: uninitialized constant I18n::HashRefinements ``` The I18n internal hash structure also changed sightly, so this fix accomodates that. Deprecated Ruby versions (< 2.7) are also removed for good measure. Related I18n issue: - ruby-i18n/i18n#602
thibaudgg
added a commit
to electric-feel/i18n-backend-side_by_side
that referenced
this pull request
Mar 20, 2022
This upgrades the logic to support the I18n 1.10.0 release, that was broking with issue like: ``` LoadError: cannot load such file -- i18n/core_ext/hash ``` or ``` NameError: uninitialized constant I18n::HashRefinements ``` The I18n internal hash structure also changed sightly, so this fix accomodates that. Deprecated Ruby versions (< 2.7) are also removed for good measure. Related I18n issue: - ruby-i18n/i18n#602
thibaudgg
added a commit
to electric-feel/i18n-backend-side_by_side
that referenced
this pull request
Mar 20, 2022
This upgrades the logic to support the I18n 1.10.0 release, that was broking with issue like: ``` LoadError: cannot load such file -- i18n/core_ext/hash ``` or ``` NameError: uninitialized constant I18n::HashRefinements ``` The I18n internal hash structure also changed sightly, so this fix accomodates that. Deprecated Ruby versions (< 2.7) are also removed for good measure. Related I18n issue: - ruby-i18n/i18n#602
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #574
This was breaking the master build.