Repository navigation
Checkbox / Radio Button: Improve HTML whitespace sensitivity - #239
Conversation
Avoids issues where HTML spacing is sensitive between the checkmark pseudo-element and label text.
Easier to review visual regressions
I lied... the horizontal offset of the checkboxes changes ever-so-slightly. Checking out the artifacts for the build (specifically |
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, thanks for highlighting the visual diff. If it's OK with UX team it's OK with me!
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
This change looks good to me as well... I hadn't noticed that the regular checkboxes and radio buttons were offset by 4px, but agree that flush left makes more sense. Thanks for catching!
|
Noting that the upstream uswds/uswds#4286 is now merged, we'll need to come back and revisit this in the future to reconcile redundancies. |
Related: uswds/uswds#4286
Context: 18F/identity-idp#5279 (comment)
This pull request seeks to maintain the existing visual appearance of the Checkbox and Radio Button components, while improving developer ergonomics regarding HTML whitespace sensitivity.
See additional details at uswds/uswds#4286 .
The expectation is that there should be no user-facing visual effect of these changes, hopefully demonstrated by a passing visual regression test.
This does not incorporate other design revisions proposed for the checkbox and radio component, which will be implemented separately.