Visitar URL original
Upgrade USWDS from 2.11.2 to 2.12.1 by aduth · Pull Request #243 · 18F/identity-design-system · GitHub
Skip to content

Upgrade USWDS from 2.11.2 to 2.12.1 - #243

Merged
aduth merged 1 commit into
mainfrom
aduth-uswds-2-12
Aug 27, 2021
Merged

aduth merged 1 commit into
mainfrom
aduth-uswds-2-12

Conversation

@aduth

@aduth aduth commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

Why: Avoid future maintenance overhead incurred by version drift, incorporate latest features and updates, including upstream contributions previously implemented as overrides.

Changelog:

Incorporated revisions:

@aduth

aduth commented Aug 25, 2021

Copy link
Copy Markdown
Contributor Author

@anniehirshman-gsa FYI I noticed there were some changes to the display of external links in USWDS included in this release via uswds/uswds#4277 . May be worth a second look if you're interested in potential regressions (example).

@zachmargolis zachmargolis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/scss/components/_inputs.scss
**Why:** Avoid future maintenance overhead incurred by version drift, incorporate latest features and updates, including upstream contributions previously implemented as overrides.

Changelog:
- https://github.com/uswds/uswds/releases/tag/v2.12.1
- https://github.com/uswds/uswds/releases/tag/v2.12.0

Incorporated revisions:
- uswds/uswds#4199
- uswds/uswds#4286
@aduth
aduth force-pushed the aduth-uswds-2-12 branch from 90c41bb to 826fcf0 Compare August 27, 2021 15:18
@aduth

aduth commented Aug 27, 2021

Copy link
Copy Markdown
Contributor Author

Ran visual regression locally, and looks clean aside from small line-height adjustment caused by the changes to external links, as well as updated version number on the homepage.

Double-checked with @anniehirshman-gsa that bigger external icon will work as well, and will follow up to update Figma designs accordingly.

@aduth
aduth merged commit 92a74a9 into main Aug 27, 2021
@aduth
aduth deleted the aduth-uswds-2-12 branch August 27, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants