fix(review): an honest PR comment: real lint-only banner, AI lane status, PR intent, project_dir - #1720

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At docs/docs/usage/dbt-pr-review.md, line 218:

<comment>In a monorepo the base-compile example writes `target-base/` at the repo root and runs `dbt` from the repo root, but the reviewer reads `target-base/` relative to `project_dir`. Equivalence and column-breakage checks would silently fall back to not verified. Note that the base compile must target `<project_dir>/target-base` and run inside the project folder, or the Monorepos paragraph should say so.</comment>

<file context>
@@ -199,6 +199,34 @@ jobs:
+      - name: Compile the base into target-base/
+        run: |
+          git worktree add ../base "origin/${{ github.base_ref }}"
+          (cd ../base && dbt deps && dbt compile --target-path "$GITHUB_WORKSPACE/target-base")
+```
+
</file context>

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/opencode/src/altimate/review/ai-review.ts, line 66:

<comment>`safeReason` still exposes credential formats that do not use the four dashed prefixes, so provider failures can disclose secrets in PR comments. Reuse the repository's credential/error redactor or mask credential-labeled values and credential-bearing URLs before truncating the reason.

(Based on your team's feedback about masking credential-stem error values.) [a5c5a10f-6a4a-4e42-8c2e-f8e01b48683d]</comment>

<file context>
@@ -31,6 +32,39 @@ export interface AiReviewInput {
+  return raw
+    .replace(/\s+/g, " ")
+    .replace(/(bearer\s+)[^\s]+/gi, "$1***")
+    .replace(/\b(sk|pk|key|token)[-_][A-Za-z0-9_-]{8,}/gi, "***")
+    .slice(0, 200)
 }
</file context>

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/opencode/src/altimate/review/orchestrate.ts, line 1418:

<comment>Empty-scope reviews now emit an AI `skipped` status and coverage note even though there is no review scope or AI lane to skip. Guard the AI-status block on a non-empty review scope so empty reviews leave `ai` undefined.</comment>

<file context>
@@ -1410,7 +1414,12 @@ export async function runReview(input: OrchestrateInput): Promise<VerdictEnvelop
   // headless-without-model) — the review degrades to deterministic-only.
-  if (lanes.has("ai_review") && input.aiReview) {
+  let aiStatus: AiLaneStatus | undefined
+  if (!lanes.has("ai_review")) {
+    aiStatus = { state: "skipped", reason: `not part of the ${tier} tier` }
+  } else if (!input.aiReview) {
</file context>

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/opencode/src/altimate/review/orchestrate.ts, line 1444:

<comment>AI callback failures bypass the redaction promised by `AiLaneStatus` and can publish raw error text in the signed envelope and PR comment. Apply the same credential-safe error formatter before storing `ai.reason`. 

(Based on your team's feedback about masking credential-bearing error text.) [173edeff-f795-42ca-9d7d-86524f63e58a]</comment>

<file context>
@@ -1419,16 +1428,20 @@ export async function runReview(input: OrchestrateInput): Promise<VerdictEnvelop
-      // A failed AI lane must never fail the review.
+    } catch (err) {
+      // A failed AI lane must never fail the review — but it must say so.
+      aiStatus = { state: "error", reason: String((err as Error)?.message ?? err).slice(0, 200) }
     }
   }
</file context>

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At github/review/action.yml, line 189:

<comment>A misspelled `project_dir` silently broadens a monorepo review to every changed file. Validate that the directory contains `dbt_project.yml`/`.yaml` before adding `--cwd`, or make the review fail closed when project discovery fails.</comment>

<file context>
@@ -181,6 +186,7 @@ runs:
         ALTIMATE_REVIEW_SIGNING_KEY: ${{ inputs.signing_key }}
       run: |
         args=(--mode "$IN_MODE" --manifest "$IN_MANIFEST" --severity "$IN_SEVERITY")
+        [[ -n "$IN_PROJECT_DIR" && "$IN_PROJECT_DIR" != "." ]] && args+=(--cwd "$IN_PROJECT_DIR")
         [[ -n "$IN_BASE" ]] && args+=(--base "$IN_BASE")
         [[ -n "$IN_HEAD" ]] && args+=(--head "$IN_HEAD")
</file context>

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/opencode/src/altimate/review/format.ts, line 144:

<comment>The PR comment does not report the AI lane’s available model and duration: successful runs show only the model, while failed or timed-out runs show only state and reason. Include model and duration in the rendered AI status.</comment>

<file context>
@@ -110,11 +111,41 @@ export function renderSummary(env: VerdictEnvelope): string {
+    notes.push(`${env.scope.outOfScopeFiles} changed file(s) outside the dbt project were not reviewed.`)
+  if (env.ai && env.ai.state !== "ok") {
+    const what = { skipped: "skipped", timeout: "timed out", error: "failed" }[env.ai.state]
+    notes.push(`Advisory AI review ${what}${env.ai.reason ? `: ${env.ai.reason}` : ""}.`)
+  }
+  return notes.length ? [...notes.map((n) => `> ℹ️ ${n}`), ""] : []
</file context>

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/opencode/src/altimate/review/format.ts, line 136:

<comment>Mixed head/base compile failures are rendered with the first model’s reason for every model, which misstates review coverage. Group the entries by reason or render each model with its own reason.</comment>

<file context>
@@ -110,11 +111,41 @@ export function renderSummary(env: VerdictEnvelope): string {
+    const head = unverified.slice(0, 5).map((u) => `\`${u.path}\``).join(", ")
+    const more = unverified.length > 5 ? ` and ${unverified.length - 5} more` : ""
+    notes.push(
+      `${unverified.length} model(s) not verified by the engine — ${unverified[0].reason}: ${head}${more}. ` +
+        "Run `dbt compile` (and compile the base into `target-base/`) for equivalence and lineage checks.",
+    )
</file context>

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/opencode/src/altimate/telemetry/index.ts, line 1606:

<comment>`ai_state` is typed as `string`, but the AI lane only produces `ok | skipped | timeout | error`. Narrow the type to that union so the telemetry contract matches the envelope schema and typos are caught at compile time.</comment>

<file context>
@@ -1594,10 +1594,20 @@ export namespace Telemetry {
+        /** Models the engine could not verify (no compiled SQL). */
+        unverified_models?: number
+        /** Advisory AI lane outcome: ok | skipped | timeout | error. */
+        ai_state?: string
+        ai_duration_ms?: number
+        /** Where the review base came from (flag, github_event, default_branch, …). */
</file context>

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/opencode/test/altimate/review-ci-honesty.test.ts, line 157:

<comment>This test creates a temp directory and never removes it, so every run leaves a `review-event-*` directory behind. Remove it in a `finally` block (`fs.rm(dir, { recursive: true, force: true })`) or use the repo's tmpdir fixture with auto cleanup.</comment>

<file context>
@@ -0,0 +1,188 @@
+
+describe("PR title and description reach the intent check", () => {
+  test("GitHub: read from the pull_request event", async () => {
+    const dir = await fs.mkdtemp(path.join(tmpdir(), "review-event-"))
+    const ev = path.join(dir, "event.json")
+    await fs.writeFile(ev, JSON.stringify({ pull_request: { title: "Add fct_orders", body: "## Spec\n- grain: order_id" } }))
</file context>