Visitar URL original
fix #10613: Add default CRUD server group by gramian · Pull Request #10778 · ArcadeData/arcadedb · GitHub
Skip to content

fix #10613: Add default CRUD server group - #10778

Merged
robfrank merged 1 commit into
ArcadeData:mainfrom
gramian:main
Oct 28, 2026
Merged

fix #10613: Add default CRUD server group#10778
robfrank merged 1 commit into
ArcadeData:mainfrom
gramian:main

Conversation

@gramian

@gramian gramian commented Oct 27, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

What does this PR do?

This change adds crud server group to server-groups.json.

Motivation

It fills a read/write user gap between the admin and the readonly groups.

Related issues

#10613

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

Summary by CodeRabbit

  • New Features
    • Added a crud server group with create, read, update, and delete access across record types, and no result-set limit.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 195bb2a7-2cd3-47cd-8a6c-1bb6061a4a8f
Commits

Reviewing files that changed from the base of the PR and between 1993631 and d233de3.

Files selected for processing: 1
  • package/src/main/config/server-groups.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The server configuration adds a crud group with empty group-level access, an unlimited result-set limit, and wildcard access for create, read, update, and delete operations.

Changes: CRUD Server Group

Layer / File(s) Summary
Configure CRUD access
package/src/main/config/server-groups.json		 The configuration adds the crud group with empty group-level access, resultSetLimit set to -1, and wildcard type access for create, read, update, and delete operations.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Feature

Suggested labels: enhancement

Suggested reviewers: lvca, robfrank

Merge Risk: Minimal · up to d233d

The new group provides the intended CRUD access without a demonstrated merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description covers the change, motivation, related issue, and build checklist. It omits the optional Additional Notes section and leaves the unit-test checklist item unchecked, but it is otherwise…
Title check Passed The title clearly and concisely describes the main change: adding the default CRUD server group.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description covers the change, motivation, related issue, and build checklist. It omits the optional Additional Notes section and leaves the unit-test checklist item unchecked, but it is otherwise complete and relevant.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

codacy-production Bot commented Oct 27, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mergify

mergify Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@robfrank robfrank changed the title Add default CRUD server group fix #10613: Add default CRUD server group Oct 28, 2026
@robfrank
robfrank merged commit 15d0218 into ArcadeData:main Oct 28, 2026
23 of 28 checks passed
@tae898 tae898 mentioned this pull request Nov 4, 2026
Closed
robfrank pushed a commit that referenced this pull request Nov 5, 2026
@gramian @robfrank
fix #10613: Add default CRUD server group (#10778)
47285b3 
(cherry picked from commit 15d0218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gramian @robfrank