Visitar URL original
ci(#11180): run LSMVectorIndexTest in the slow lane again by lvca · Pull Request #11181 · ArcadeData/arcadedb · GitHub
Skip to content

ci(#11180): run LSMVectorIndexTest in the slow lane again - #11181

Merged
lvca merged 1 commit into
mainfrom
ci-fold-lsm-vector-shard
Nov 3, 2026
Merged

lvca merged 1 commit into
mainfrom
ci-fold-lsm-vector-shard

Conversation

@lvca

@lvca lvca commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Closes #11180.

Undoes the split of the slow lane from #10887: one job, with the command, report name and artifact names it had before. The coverage collector takes one slow-lane suite again.

The split existed because LSMVectorIndexTest took ~20 minutes; since #11175 it takes 94 s (run 41548619986), so the merged lane is about as long as its rest shard was (22 min), well under the modules lane (34 min), and CI uses one runner fewer.

Checked: the workflow YAML parses, the workflow lint scripts and .github/scripts/tests/test-ci-scripts.sh (234 checks) pass. The coverage-report job of this PR's run confirms the collector change.

Summary by CodeRabbit

  • Chores
    • Consolidated the slow unit-test run into a single job, excluding vector-tagged tests.
    • Combined test and coverage reports under shared artifact names.

@lvca lvca added this to the 26.11.1 milestone Nov 3, 2026
@lvca lvca added performance build Maven reactor, CI workflows, coverage aggregation labels Nov 3, 2026
@lvca lvca self-assigned this Nov 3, 2026
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The slow-test lane no longer uses a two-shard matrix. The workflow uses shared test-report and coverage artifact names, then registers one slow-test coverage suite.

Changes: Slow-test CI lane

Layer / File(s) Summary
Run and report slow tests
.github/workflows/mvn-test.yml
The slow-test job runs without a shard matrix and runs the engine’s slow tests while excluding vector-tagged tests. Its reporter name and test-report and coverage artifacts use shared names.
Collect slow-test coverage
.github/workflows/mvn-test.yml
Coverage collection downloads one slow-test coverage artifact and registers one slow-unit-tests suite.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

  • ArcadeData/arcadedb#10887: This PR introduced the slow-test shard matrix and shard-specific artifact names that this change consolidates.

Suggested reviewers: agarg21

Merge Risk: Minimal · up to a634d

The requested test is included in the consolidated slow lane, and no merge-blocking issue was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the main change: restoring LSMVectorIndexTest to the slow CI lane.
Description check Passed The description explains the change, motivation, related issue, implementation details, and validation results. It does not use the template headings or confirm the two checklist items, but it is most…
Linked Issues check Passed Issue #11180 requires one slow-lane job that includes LSMVectorIndexTest and uses one fewer runner. The workflow removes the matrix split and removes the -Dtest selector, so the slow suite runs in…
Out of Scope Changes check Passed The diff changes only the slow-lane workflow, its report and coverage artifact names, and the matching coverage collector inputs. These changes directly support merging the shard and preserving covera…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Description check

Explanation

The description explains the change, motivation, related issue, implementation details, and validation results. It does not use the template headings or confirm the two checklist items, but it is mostly complete and relevant.

Full details: Linked Issues check

Explanation

Issue #11180 requires one slow-lane job that includes LSMVectorIndexTest and uses one fewer runner. The workflow removes the matrix split and removes the -Dtest selector, so the slow suite runs in one job with vector-tagged tests excluded. The coverage collector now downloads and registers one slow-unit-test artifact. The change also restores shared report and artifact names. The PR description reports successful workflow parsing and CI-script checks.

Full details: Out of Scope Changes check

Explanation

The diff changes only the slow-lane workflow, its report and coverage artifact names, and the matching coverage collector inputs. These changes directly support merging the shard and preserving coverage collection. No unrelated source or configuration changes appear in the reviewed diff.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/bash/security/wget-pipe-to-shell-bash.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b714463b-7e17-47bb-86f4-8a0bf56f6d80
Commits

Reviewing files that changed from the base of the PR and between aa6f2f8 and a634daf.

Files selected for processing: 1
  • .github/workflows/mvn-test.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@mergify

mergify Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@codacy-production

codacy-production Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage ∅ diff coverage · -4.62% coverage variation

Metric Results
Coverage variation ✅ -4.62% coverage variation
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aa6f2f8) 259040 226511 87.44%
Head commit (a634daf) 291867 (+32827) 241727 (+15216) 82.82% (-4.62%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11181) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@claude

claude Bot commented Nov 3, 2026

Copy link
Copy Markdown

Review: this is a clean revert of the slow-lane split from #10887. The matrix, artifact names and collector arguments all go back to the single-job names. I grepped .github for leftover references to the old shard names (lsm-vector, slow-unit-tests-rest, Slow Unit Tests Report () and found none. That includes branch-protection or script references.

  • Tests: none are needed, since this is CI-only.
  • Security: nothing new. The action pins are unchanged and no permissions changed.
  • Timeout: the 90-minute cap still leaves plenty of headroom over the roughly 22 minute merged lane.
  • Required checks: if branch protection requires the old matrix check names (... (lsm-vector) or ... (rest)), update them after merge. I could not check that from here.

LGTM.

@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.35%. Comparing base (aa6f2f8) to head (a634daf).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11181   +/-   ##
=========================================
  Coverage     79.34%   79.35%           
- Complexity     4959     4961    +2     
=========================================
  Files          2322     2322           
  Lines        259040   259040           
  Branches      56762    56762           
=========================================
+ Hits         205542   205561   +19     
+ Misses        32569    32557   -12     
+ Partials      20929    20922    -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lvca
lvca merged commit dc99d16 into main Nov 3, 2026
39 of 41 checks passed
@lvca
lvca deleted the ci-fold-lsm-vector-shard branch November 3, 2026 03:02
robfrank pushed a commit that referenced this pull request Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Maven reactor, CI workflows, coverage aggregation performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: run LSMVectorIndexTest in the slow lane again

1 participant