Visitar URL original
fix(server): remove PEP 765 return in finally from playground_users.get_user by amasen02 · Pull Request #15964 · Arize-ai/phoenix · GitHub
Skip to content

fix(server): remove PEP 765 return in finally from playground_users.get_user - #15964

Merged
axiomofjoy merged 2 commits into
Arize-ai:mainfrom
amasen02:fix/playground-users-pep-765-finally-return-15963
Sep 8, 2026
Merged

axiomofjoy merged 2 commits into
Arize-ai:mainfrom
amasen02:fix/playground-users-pep-765-finally-return-15963

Conversation

@amasen02

@amasen02 amasen02 commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

resolves #15963

…et_user

Remove return from finally block in get_user to comply with PEP 765 on Python 3.14+.
Safely wrap fallback user identity resolution in try/except to maintain intended fallback semantics when auth is not available.
Add comprehensive unit tests for get_user across request and fallback scenarios.

resolves Arize-ai#15963
@amasen02
amasen02 requested a review from a team as a code owner September 5, 2026 16:23
@github-project-automation github-project-automation Bot moved this to 📘 Todo in phoenix Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot added the triage issues that need triage label Sep 5, 2026
@amasen02

amasen02 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Sep 5, 2026
@amasen02

amasen02 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@github-project-automation github-project-automation Bot moved this from 📘 Todo to 👍 Approved in phoenix Sep 8, 2026
@axiomofjoy
axiomofjoy enabled auto-merge (squash) September 8, 2026 15:19
@axiomofjoy
axiomofjoy merged commit 9c531a5 into Arize-ai:main Sep 8, 2026
43 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Approved to ✅ Done in phoenix Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage issues that need triage

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

PEP 765 SyntaxWarning: return in finally in playground_users.get_user

2 participants