Repository navigation
Fix npm install and C++ compilation errors on Node 24 - #10
yumin-chen wants to merge 6 commits into
Conversation
Require node >= 22 and use NAPI_VERSION=10
- Fix invalid initializer for persistentStorage std::map in AsyncWorker constructor - Fix duplicate destructor definition in NodeGitWrapper, defining DestroyNative() correctly - Wrap deprecated OpenSSL locking callback cleanup in OPENSSL_VERSION_NUMBER < 1.1 check Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
f99272f to
0be17d3
Compare
1 participant
Fixes compilation errors during
npm installon newer Node.js versions (such as Node 24) by:persistentStorageinitializer inAsyncWorkerconstructor (generate/templates/manual/src/async_worker.cc).DestroyNative()inNodeGitWrapper(generate/templates/manual/src/nodegit_wrapper.cc).#if OPENSSL_VERSION_NUMBER < 0x10100000Lingenerate/templates/templates/nodegit.cc.PR created automatically by Jules for task 10188625528025009261 started by @yumin-chen