Repository navigation
Fix native binding generation and C++ compilation issues - #6
yumin-chen wants to merge 6 commits into
Conversation
Require node >= 22 and use NAPI_VERSION=10
- Fix promise return in generateNativeCode.js and partial filter registration - Add missing <cassert> headers in wrappers - Add node-addon-api target dependency in binding.gyp templates - Resolve duplicate int64/uint64 type overloads in v8_helpers.h for Linux - Add exception-safe CallJSFunction and IsError wrappers for callbacks - Ensure callback structs are copied in async batons to avoid dangling pointers Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
f99272f to
ba0e77d
Compare
1 participant
Resolves template code generation, binding.gyp dependencies, type overload collisions on Linux, and callback exception/memory safety issues in C++ bindings. Re-generated native code and verified clean compilation and test execution.
PR created automatically by Jules for task 13343314417107238059 started by @yumin-chen