Visitar URL original
getMessages returns now a IAsyncEnumerable by Plerx2493 · Pull Request #1641 · DSharpPlus/DSharpPlus · GitHub
Skip to content

getMessages returns now a IAsyncEnumerable - #1641

Merged
akiraveliara merged 9 commits into
masterfrom
fix/getMessages
Oct 7, 2023
Merged

akiraveliara merged 9 commits into
masterfrom
fix/getMessages

Conversation

@Plerx2493

@Plerx2493 Plerx2493 commented Oct 5, 2023 •

Copy link
Copy Markdown
Member

Summary

Implement the methods as IAsyncEnumerable

Details

Untested, i will test i tomorrow

@Plerx2493 Plerx2493 added this to the v5.0 milestone Oct 5, 2023
* TrygetHeader and is exemptFromGlobalLimit check

* erm
* update polly

* Build request for each try

* erm idk

* all i have to say then is "please using the request message"

* only one req
@Plerx2493
Plerx2493 marked this pull request as ready for review October 7, 2023 13:50
@akiraveliara
akiraveliara merged commit 603876b into master Oct 7, 2023
@Plerx2493
Plerx2493 deleted the fix/getMessages branch October 7, 2023 14:05
OoLunar pushed a commit that referenced this pull request Oct 3, 2024
* getMessages returns now a IAsyncEnumerable

* erm

* Reverse loop instead of collection

* Fix/ratelimit policy (#1642)

* TrygetHeader and is exemptFromGlobalLimit check

* erm

* Fix issue with ratelimiting (#1643)

* update polly

* Build request for each try

* erm idk

* all i have to say then is "please using the request message"

* only one req

* getMessages returns now a IAsyncEnumerable

* erm

* Reverse loop instead of collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants