Visitar URL original
Create an analyzer for DSharpPlus by Instellate · Pull Request #2154 · DSharpPlus/DSharpPlus · GitHub
Skip to content

Create an analyzer for DSharpPlus - #2154

Merged
akiraveliara merged 45 commits into
masterfrom
instellate/analyzer
May 18, 2025
Merged

akiraveliara merged 45 commits into
masterfrom
instellate/analyzer

Conversation

@Instellate

@Instellate Instellate commented Nov 4, 2024 •

Copy link
Copy Markdown
Member

Summary

Make an analyzer for DSharpPlus that tells the user various wrong usage of the library. Related to #2096

Notes

I do not know if this is too barebones to be merged yet. If it is good enough I will convert it from a draft to a pull request.
How documentation needs to be done is also a discussion that is needed to be done.
There's also typos and stuff so if anyone have time preferably commit it to the branch, otherwise leave it as a review.

@Instellate
Instellate marked this pull request as ready for review November 6, 2024 21:34
Comment thread docs/articles/analyzers/rules.md Resolved
Also made more tests for SingleEntityGetRequestAnalyzer

@akiraveliara akiraveliara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it appears that you're fundamentally misunderstanding how permissions work. everything else looks... fine? i don't understand the recent severity changes, though

Comment thread docs/articles/analyzers/core.md Resolved
@Instellate

Instellate commented Mar 4, 2025 •

Copy link
Copy Markdown
Member Author

There is one more change needed to be done and that is to package the analyzer dll into the DSharpPlus core project. After that the PR should be 100% ready to merge unless any more changes will be requested.

Found this article that guides on how to do that. So I will use that as an example and implement it later this evening (CET).

Comment thread docs/articles/analyzers/core.md Resolved
@Instellate
Instellate requested a review from akiraveliara May 18, 2025 18:17
@akiraveliara
akiraveliara merged commit 4cc4134 into master May 18, 2025
@akiraveliara
akiraveliara deleted the instellate/analyzer branch May 18, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants