Visitar URL original
Soundboard by Plerx2493 · Pull Request #2331 · DSharpPlus/DSharpPlus · GitHub
Skip to content

Soundboard - #2331

Draft
Plerx2493 wants to merge 13 commits into
masterfrom
plerx/dev/soundboard
Draft

Soundboard#2331
Plerx2493 wants to merge 13 commits into
masterfrom
plerx/dev/soundboard

Conversation

@Plerx2493

@Plerx2493 Plerx2493 commented May 29, 2025

Copy link
Copy Markdown
Member

No description provided.

@Plerx2493 Plerx2493 added this to the v5.0 milestone May 29, 2025
@Plerx2493 Plerx2493 self-assigned this May 29, 2025
akiraveliara
akiraveliara requested changes May 29, 2025
View reviewed changes

@akiraveliara akiraveliara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to the other comments, please ensure xmldocs in DiscordSoundboardSound are complete sentences and terminated properly - in particular, the skipCache documentation does not at all clarify what the parameter does without background knowledge.

Comment thread DSharpPlus/Net/Rest/DiscordRestApiClient.cs Resolved
Comment thread DSharpPlus/Net/Rest/DiscordRestApiClient.cs Resolved
Comment thread DSharpPlus/InlineMediaTool.cs Resolved
Comment thread DSharpPlus/Entities/Guild/DiscordSoundboardSound.cs Resolved
Comment thread DSharpPlus/Clients/DiscordClient.cs Resolved
@Plerx2493

Plerx2493 commented May 29, 2025

Copy link
Copy Markdown
Member Author

Aki, thanks for the review but the pr is highly wip and therefore a draft

@Plerx2493

Plerx2493 commented May 29, 2025

Copy link
Copy Markdown
Member Author

Maybe i should have put that in the description

@Plerx2493
Plerx2493 force-pushed the plerx/dev/soundboard branch from 39036f5 to 91263db Compare July 12, 2025 10:14
@Plerx2493
Plerx2493 force-pushed the plerx/dev/soundboard branch from f64af16 to 1d6fcfb Compare March 30, 2026 09:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akiraveliara akiraveliara akiraveliara requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Plerx2493 Plerx2493

Labels

core enhancement new-features

Projects

None yet

Milestone

v5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Plerx2493 @akiraveliara