Visitar URL original
Make 3D Triangulate possible with pytorch_dlc branch and MA project by Zelin2001 · Pull Request #2729 · DeepLabCut/DeepLabCut · GitHub
Skip to content

Make 3D Triangulate possible with pytorch_dlc branch and MA project - #2729

Merged
MMathisLab merged 3 commits into
DeepLabCut:pytorch_dlcfrom
Saintgene-Xu-lab:pytorch_triangulate
Sep 9, 2024
Merged

Make 3D Triangulate possible with pytorch_dlc branch and MA project#2729
MMathisLab merged 3 commits into
DeepLabCut:pytorch_dlcfrom
Saintgene-Xu-lab:pytorch_triangulate

Conversation

@Zelin2001

@Zelin2001 Zelin2001 commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Rationality

I proceeded with my project, and then found the triangulate() function dependent on TensorFlow modules. Further debugging revealed more problems relating to the 'single' individual, who has a different bodypart dimension from common individuals.

Finally, I made minor changes to make triangulation work on my dataset. These changes might also help with other 3D MA users.

Changes

  • Compute triangulated data with pose_estimation_pytorch

  • Make correct MultiIndex with unique bodyparts

  • adapt to DataFrame.to_hdf() changes

@Zelin2001
Bugfix: triangulation
3e75f90 
* Compute triangulated data with pose_estimation_pytorch
* Make correct MultiIndex with unique bodyparts
* adapt to DataFrame.to_hdf() changes
@MMathisLab
MMathisLab requested a review from AlexEMG September 5, 2024 15:47
@MMathisLab

MMathisLab commented Sep 5, 2024

Copy link
Copy Markdown
Member

thanks so much for your contribution! This is super helpful!

@MMathisLab
MMathisLab requested a review from n-poulsen September 5, 2024 15:48
@MMathisLab MMathisLab added 3D questions/code issues regarding 3D DLC DLC3.0🔥 labels Sep 5, 2024
n-poulsen
n-poulsen suggested changes Sep 6, 2024
View reviewed changes

@n-poulsen n-poulsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zelin2001, this looks great! Just suggested a few changes, let me know if you want to discuss anything.

One the changes are made this looks good to me :)

Comment thread deeplabcut/pose_estimation_3d/triangulation.py Resolved
Comment thread deeplabcut/pose_estimation_3d/triangulation.py Resolved
Comment thread deeplabcut/pose_estimation_3d/triangulation.py Resolved
Comment thread deeplabcut/pose_estimation_3d/triangulation.py Resolved
Comment thread deeplabcut/pose_estimation_3d/triangulation.py Resolved
@Zelin2001

Zelin2001 commented Sep 7, 2024

Copy link
Copy Markdown
Contributor Author

Thanks @Zelin2001, this looks great! Just suggested a few changes, let me know if you want to discuss anything.

One the changes are made this looks good to me :)

Thank you a lot for the advice @n-poulsen . I've learned more about deeplabcut from these changes.

@Zelin2001
Zelin2001 requested a review from n-poulsen September 7, 2024 07:40
n-poulsen
n-poulsen approved these changes Sep 9, 2024
View reviewed changes

@n-poulsen n-poulsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @Zelin2001!

@MMathisLab
MMathisLab merged commit 55de11b into DeepLabCut:pytorch_dlc Sep 9, 2024
@Zelin2001
Zelin2001 deleted the pytorch_triangulate branch September 10, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MMathisLab MMathisLab MMathisLab approved these changes
@AlexEMG AlexEMG Awaiting requested review from AlexEMG
+1 more reviewer
@n-poulsen n-poulsen n-poulsen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3D questions/code issues regarding 3D DLC DLC3.0🔥

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zelin2001 @MMathisLab @n-poulsen