Visitar URL original
Plot detector's bboxes if Top-Down architecture by maximpavliv · Pull Request #2791 · DeepLabCut/DeepLabCut · GitHub
Skip to content

Plot detector's bboxes if Top-Down architecture - #2791

Merged
n-poulsen merged 13 commits into
pytorch_dlcfrom
maxim/save_plot_bboxes
Dec 13, 2024
Merged

Plot detector's bboxes if Top-Down architecture#2791
n-poulsen merged 13 commits into
pytorch_dlcfrom
maxim/save_plot_bboxes

Conversation

@maximpavliv

@maximpavliv maximpavliv commented Nov 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR introduces the plotting of the detector's bounding boxes, if the architecture is Top-Down.

In particular, the bounding boxes are:

  • Saved in the *_full.pickle file during video analysis
  • Plotted by evaluate_network() when passing argument plotting=True
  • Plotted by create_video_with_all_detections(), unless passing argument plot_bboxes=False
  • Plotted by create_labeled_video(), unless passing argument plot_bboxes=False
  • Plotted by video_inference_superanimal() , unless passing argument plot_bboxes=False
  • Plotted by visualize_predictions() , unless passing argument plot_bboxes=False

maximpavliv
maximpavliv commented Nov 20, 2024
View reviewed changes
Comment thread deeplabcut/pose_estimation_pytorch/modelzoo/inference.py Resolved
Comment thread deeplabcut/utils/make_labeled_video.py Resolved
Comment thread deeplabcut/utils/auxfun_multianimal.py Resolved
Comment thread deeplabcut/utils/make_labeled_video.py Resolved
@maximpavliv maximpavliv added enhancement New feature or request DLC3.0🔥 labels Nov 21, 2024
@maximpavliv
maximpavliv force-pushed the maxim/save_plot_bboxes branch from a4212ff to e245a0b Compare November 22, 2024 18:40
n-poulsen
n-poulsen suggested changes Nov 25, 2024
View reviewed changes

@n-poulsen n-poulsen left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes (mostly the mutable default argument), otherwise looks good to me!

Comment thread deeplabcut/pose_estimation_pytorch/modelzoo/inference.py Resolved
Comment thread deeplabcut/utils/visualization.py Resolved
Comment thread deeplabcut/utils/visualization.py Resolved
@maximpavliv
maximpavliv force-pushed the maxim/save_plot_bboxes branch 2 times, most recently from 45efa3c to 320a03f Compare December 9, 2024 14:31
@maximpavliv
maximpavliv requested a review from n-poulsen December 9, 2024 14:32
@maximpavliv
maximpavliv force-pushed the maxim/save_plot_bboxes branch from 320a03f to 84c06f7 Compare December 12, 2024 18:09
n-poulsen
n-poulsen suggested changes Dec 13, 2024
View reviewed changes

@n-poulsen n-poulsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo to fix but otherwise LGTM!

Comment thread deeplabcut/pose_estimation_pytorch/apis/evaluate.py Resolved
@maximpavliv
maximpavliv force-pushed the maxim/save_plot_bboxes branch from 4aa0354 to 74bab25 Compare December 13, 2024 09:28
@n-poulsen
n-poulsen merged commit 9b0d7f4 into pytorch_dlc Dec 13, 2024
@n-poulsen
n-poulsen deleted the maxim/save_plot_bboxes branch December 13, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@n-poulsen n-poulsen n-poulsen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DLC3.0🔥 enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maximpavliv @n-poulsen