Visitar URL original
Fix network-drive path corruption in `read_config()` and related call sites by deruyter92 · Pull Request #3349 · DeepLabCut/DeepLabCut · GitHub
Skip to content

Fix network-drive path corruption in read_config() and related call sites #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deruyter92 wants to merge 16 commits into from
Closed

Fix network-drive path corruption in read_config() and related call sites #3349

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3b8c44a
fix path resolution on network drives. Replace Path(..).resolve() wi…
deruyter92 May 29, 2026
fddcbaa
Add safe_resolve helper for path resolution
deruyter92 May 29, 2026
65f8dfb
fix redundant resolution of resolved path in memory_replay.py
deruyter92 May 29, 2026
6bbe26d
fix open -> os.stat
deruyter92 May 29, 2026
3f93a76
replace os.stat -> open for files, listdir for dirs.
deruyter92 May 29, 2026
87cd6aa
fix TestReadConfigProjectPath
deruyter92 May 29, 2026
8be1c26
Update deeplabcut/utils/auxiliaryfunctions.py
deruyter92 May 29, 2026
5ec1023
Merge remote-tracking branch 'upstream/main' into jaap/safe_resolve_p…
deruyter92 Jun 26, 2026
f422dcc
Merge branch 'main' into jaap/safe_resolve_paths
C-Achard Jun 29, 2026
9d2732b
Adjust config path tests for Path objects
C-Achard Jun 29, 2026
bb23a34
address remaining `.resolve()` cases: prefer `.absolute()`, or otherw…
deruyter92 Jul 6, 2026
831cb1d
update `safe_resolve`: add logging, use os.stat (more efficient)
deruyter92 Jul 6, 2026
77bf7f0
update test safe_resolve: allow fallback and test open/closing instead
deruyter92 Jul 6, 2026
ca63582
Merge remote-tracking branch 'upstream/main' into jaap/safe_resolve_p…
deruyter92 Jul 6, 2026
205b550
fix remaining Path.resolve()
deruyter92 Jul 7, 2026
6cefbb6
Merge branch 'main' into jaap/safe_resolve_paths
deruyter92 Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update deeplabcut/utils/auxiliaryfunctions.py
  • Loading branch information
@deruyter92
deruyter92 authored May 29, 2026
commit 8be1c265e6a2bc6336d2beab0a6adf76bf572ffd
1 change: 1 addition & 0 deletions deeplabcut/utils/auxiliaryfunctions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ def safe_resolve(path: Path) -> Path:
resolved = path.resolve()
try:
if resolved.is_dir():
# test if os.listdir works after str-conversion
os.listdir(str(resolved))
Comment thread
deruyter92 marked this conversation as resolved.
Resolved
else:
open(str(resolved)).close()
Expand Down
Loading