Visitar URL original
Fix SkeletonBuilder initialization from GUI by C-Achard · Pull Request #3380 · DeepLabCut/DeepLabCut · GitHub
Skip to content

Fix SkeletonBuilder initialization from GUI #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MMathisLab merged 15 commits into from
Jun 27, 2026
Merged

Fix SkeletonBuilder initialization from GUI #3380

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ca41e6d
Refactor SkeletonBuilder init and usage
C-Achard Jun 23, 2026
324d630
Pass parent to SkeletonBuilder
C-Achard Jun 23, 2026
999adef
Remove parent argument from SkeletonBuilder call
C-Achard Jun 23, 2026
22d3273
Persist and show SkeletonBuilder in GUI tabs
C-Achard Jun 23, 2026
17f4073
Allow positional config_path in SkeletonBuilder
C-Achard Jun 23, 2026
595df2c
Init skeleton_builder and enhance SkeletonBuilder
C-Achard Jun 24, 2026
0e327cd
Prevent duplicate SkeletonBuilder dialogs
C-Achard Jun 24, 2026
1d96caf
Handle missing 'skeleton' key in config
C-Achard Jun 24, 2026
a7197c7
Fix logging call
C-Achard Jun 24, 2026
718ab1a
Refactor SkeletonBuilder UI and add logging
C-Achard Jun 24, 2026
e48d393
Improve skeleton export and lasso selection
C-Achard Jun 24, 2026
a5563d0
Make SkeletonBuilder plot params configurable
C-Achard Jun 24, 2026
539394b
Promote SkeletonBuilder defaults to class attrs
C-Achard Jun 24, 2026
0e3ad4e
Handle skeleton export failures in GUI
C-Achard Jun 26, 2026
680e1d4
Merge branch 'main' into cy/fix-skeleton-init
C-Achard Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion deeplabcut/gui/tabs/create_videos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,4 +287,8 @@ def create_videos(self):
def build_skeleton(self, *args):
from deeplabcut.gui.widgets import SkeletonBuilder

SkeletonBuilder(self.root.config)
self.skeleton_builder = SkeletonBuilder(
config_path=self.root.config,
parent=self.root,
)
self.skeleton_builder.show()
9 changes: 6 additions & 3 deletions deeplabcut/gui/tabs/label_frames.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@

from deeplabcut.generate_training_dataset import check_labels
from deeplabcut.gui.components import DefaultTab
from deeplabcut.gui.widgets import launch_napari
from deeplabcut.utils.skeleton import SkeletonBuilder
from deeplabcut.gui.widgets import SkeletonBuilder, launch_napari


def label_frames(config_path: str | Path | None = None, image_folder: str | None = None):
Expand Down Expand Up @@ -140,4 +139,8 @@ def check_labels(self):
_ = launch_napari(labeled_images, plugin="napari", stack=True)

def build_skeleton(self, *args):
SkeletonBuilder(self.root.config)
self.skeleton_builder = SkeletonBuilder(
config_path=self.root.config,
parent=self.root,
)
self.skeleton_builder.show()
6 changes: 3 additions & 3 deletions deeplabcut/gui/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,9 +522,9 @@ def display_help(self, *args):
)


class SkeletonBuilder(QtWidgets.QDialog, BaseSkeletonBuilder):
def __init__(self, config_path, parent=None):
QtWidgets.QDialog.__init__(self, parent)
class SkeletonBuilder(BaseSkeletonBuilder, QtWidgets.QDialog):
def __init__(self, *, config_path, parent=None):
QtWidgets.QDialog.__init__(self, parent=parent)
self._parent = parent
Comment thread
C-Achard marked this conversation as resolved.
Resolved
self.setWindowTitle("Skeleton Builder")
BaseSkeletonBuilder.__init__(self, config_path)
Expand Down
Loading