Visitar URL original
minor follow-up adjustments for config GUI validation by deruyter92 · Pull Request #3399 · DeepLabCut/DeepLabCut · GitHub
Skip to content

minor follow-up adjustments for config GUI validation #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deruyter92 merged 14 commits into from
Jul 20, 2026
Merged

minor follow-up adjustments for config GUI validation #3399

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d2f3b87
squashed updates for GUI config validation error handling
deruyter92 Jul 17, 2026
c2998a7
replace getattr guard with explicit attr
deruyter92 Jul 17, 2026
4472fd3
fix: widen worker and evaluate-network error handling
deruyter92 Jul 17, 2026
a7722ef
refactor: replace QTimer.singleShot with explicit named reload timers
deruyter92 Jul 17, 2026
5bb4255
Add `MainWindow.invalidate_config_cache()`
deruyter92 Jul 17, 2026
489b39a
test: add coverage for show_task_error, cache invalidation, and reloa…
deruyter92 Jul 17, 2026
ddce16f
widen train_network error handling, similar to 4472fd3fb7fed3c8eb55ac…
deruyter92 Jul 17, 2026
7a73468
deliberately narrow down config errors. (exclude TypeError and ValueE…
deruyter92 Jul 17, 2026
91f0b2d
watch config file parent directory to detect atomic replacements
deruyter92 Jul 17, 2026
b6d86b0
guard pose_cfg.get("method") string-type
deruyter92 Jul 17, 2026
655eb9d
Add a self._extract_error flag.
deruyter92 Jul 17, 2026
3c51ff4
update tests with narrow error types
deruyter92 Jul 17, 2026
8e59c2d
Revert narrowing of CONFIG_ERRORS - treat only ValidationError as con…
deruyter92 Jul 17, 2026
6fa745c
fix MainWindow init _config_monitor
deruyter92 Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
guard pose_cfg.get("method") string-type
  • Loading branch information
@deruyter92
deruyter92 committed Jul 17, 2026
commit b6d86b043a00e4a8700db645514a2d517bf08b69
5 changes: 4 additions & 1 deletion deeplabcut/gui/displays/selected_shuffle_display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,5 +132,8 @@ def _read_pose_config(self, pose_cfg_path: Path) -> None:

self._engine = Engine.PYTORCH if "pytorch" in pose_cfg_path.stem.lower() else Engine.TF
self._net_type = pose_cfg.get("net_type", "UNKNOWN")
self._is_top_down = self._engine == Engine.PYTORCH and pose_cfg.get("method", "").lower() == "td"

method = pose_cfg.get("method")
self._is_top_down = self._engine == Engine.PYTORCH and isinstance(method, str) and method.lower() == "td"

self.pose_cfg = pose_cfg
3 changes: 2 additions & 1 deletion deeplabcut/gui/tabs/train_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ def _update_snapshot_selection_widgets_visibility(self):
self.snapshot_selection_widget.show()
# Display detector snapshot selection widget only if in Top-Down mode
pose_cfg = self._shuffle_display.pose_cfg
if pose_cfg is not None and pose_cfg.get("method", "").lower() == "td":
method = pose_cfg.get("method") if pose_cfg is not None else None
if isinstance(method, str) and method.lower() == "td":
self.detector_snapshot_selection_widget.show()
else:
self.detector_snapshot_selection_widget.hide()
Expand Down