Visitar URL original
Harden path-handling after pathlib migration by deruyter92 · Pull Request #3421 · DeepLabCut/DeepLabCut · GitHub
Skip to content

Harden path-handling after pathlib migration #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deruyter92 merged 9 commits into from
Jul 21, 2026
Merged

Harden path-handling after pathlib migration #3421

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6859773
pathlib mkdir hardening + remaining str concat fixes
deruyter92 Jul 20, 2026
7667748
hardening of path-normalization in `guarantee_multiindex_rows`
deruyter92 Jul 20, 2026
77b9e1f
remove str-required `robust_path_split` (redundant with pathlib Path)
deruyter92 Jul 20, 2026
a272894
deprecate `str`-based `grab_files_in_folder` and migrate callers to p…
deruyter92 Jul 20, 2026
0a9bbbc
fix test_auxiliary functions wrong type: tmpdir.LocalPath -> str or Path
deruyter92 Jul 20, 2026
d050c04
fix numpy to list conversion in .mat image list.
deruyter92 Jul 21, 2026
5daaade
Ensure TF branch normalizes to str ( excluded from pathlib migration)
deruyter92 Jul 21, 2026
849644a
auxfun_multianimal migrate to Path in Load and Save MA data
deruyter92 Jul 21, 2026
a1eaaae
fix pad with spaces in normalize numpy file paths
deruyter92 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test_auxiliary functions wrong type: tmpdir.LocalPath -> str or Path
  • Loading branch information
@deruyter92
deruyter92 committed Jul 21, 2026
commit 0a9bbbcbb22f90b4635c960e678e5093e74549f6
7 changes: 5 additions & 2 deletions tests/test_auxiliaryfunctions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
from deeplabcut.utils.auxfun_videos import SUPPORTED_VIDEOS


def test_find_analyzed_data(tmpdir_factory):
@pytest.mark.parametrize("path_type", [str, Path])
def test_find_analyzed_data(tmpdir_factory, path_type):
fake_folder = tmpdir_factory.mktemp("videos")
SUPPORTED_VIDEOS = ["avi"]
len(SUPPORTED_VIDEOS)
Expand All @@ -26,7 +27,7 @@ def test_find_analyzed_data(tmpdir_factory):
WRONG_SCORER = "DLC_dlcrnetms5_multi_mouseApr11shuffle3_5"

def _create_fake_file(filename):
path = str(fake_folder.join(filename))
path = Path(fake_folder) / filename
with open(path, "w") as f:
f.write("")
return path
Expand All @@ -37,6 +38,8 @@ def _create_fake_file(filename):
_ = _create_fake_file(vname + SCORER + ".pickle")
_ = _create_fake_file(vname + SCORER + ".h5")

# Test for both str and Path types (convert from tmpdir.LocalPath object)
fake_folder = path_type(fake_folder)
for ind, ext in enumerate(SUPPORTED_VIDEOS):
# test if existing models are found:
assert auxiliaryfunctions.find_analyzed_data(fake_folder, "video" + str(ind), SCORER)
Expand Down
Loading