Visitar URL original
fix faulty str / Path conversions by deruyter92 · Pull Request #3467 · DeepLabCut/DeepLabCut · GitHub
Skip to content

fix faulty str / Path conversions - #3467

Merged
deruyter92 merged 3 commits into
devfrom
jaap/pathlib-fixes
Sep 8, 2026
Merged

deruyter92 merged 3 commits into
devfrom
jaap/pathlib-fixes

Conversation

@deruyter92

@deruyter92 deruyter92 commented Aug 28, 2026 •

Copy link
Copy Markdown
Collaborator

minor fixes where str() conversion was missing

@deruyter92 deruyter92 added this to the v3.1.0 milestone Aug 28, 2026
@C-Achard
C-Achard deleted the branch dev August 31, 2026 07:33
@C-Achard C-Achard closed this Aug 31, 2026
@deruyter92 deruyter92 reopened this Aug 31, 2026
@deruyter92
deruyter92 changed the base branch from dev/tst-3.1-release to backup/dev-tst-3.1-release August 31, 2026 08:56
@deruyter92
deruyter92 changed the base branch from backup/dev-tst-3.1-release to dev August 31, 2026 09:09
… H5 conversion

Update `convertcsv2h5` to build the HDF5 output path with `Path.with_suffix(".h5")` instead of string replacement. This makes filename handling safer and consistent with `Path` objects, avoiding edge cases with `.replace()` on path strings.
@C-Achard

Copy link
Copy Markdown
Member

Ah, glad you could reopen, sorry again

@deruyter92
deruyter92 marked this pull request as ready for review September 7, 2026 07:08
@deruyter92
deruyter92 requested a review from C-Achard September 7, 2026 07:08
@deruyter92 deruyter92 added 3.0.2 and removed 3.1 labels Sep 7, 2026

@C-Achard C-Achard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deruyter92
deruyter92 merged commit 1535b51 into dev Sep 8, 2026
10 checks passed
@deruyter92
deruyter92 deleted the jaap/pathlib-fixes branch September 8, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants