Visitar URL original
Fix Faster R-CNN detector inference crashing on box_score_thresh: null by rysk-t · Pull Request #3470 · DeepLabCut/DeepLabCut · GitHub
Skip to content

Fix Faster R-CNN detector inference crashing on box_score_thresh: null #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deruyter92 merged 14 commits into from
Sep 3, 2026
Merged

Fix Faster R-CNN detector inference crashing on box_score_thresh: null #3470

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fcfb6eb
Treat a null box_score_thresh as the default detector threshold
rysk-t Aug 30, 2026
6db842d
Normalize detector box score threshold
C-Achard Aug 31, 2026
21a0eb9
Refactor detector threshold tests to config level
C-Achard Aug 31, 2026
c61ddcc
Fix incorrect import
C-Achard Aug 31, 2026
aac861c
Fix model config test defaults for TD
C-Achard Sep 1, 2026
85072d9
Use config cutoff for detector boxes
C-Achard Sep 1, 2026
7893a35
Fix detector box_score_thresh handling
C-Achard Sep 1, 2026
5e58815
Clarify detector threshold docs
C-Achard Sep 1, 2026
3e2611e
Fix `create_video_with_all_detections` -> read default `bbox_pcutoff`…
deruyter92 Sep 1, 2026
baff692
revert shared box score threshold default -> inline config default
deruyter92 Sep 1, 2026
0f5330a
update docstring for `DetectorModelConfig`
deruyter92 Sep 1, 2026
256dfb9
add test for building config with null threshold
deruyter92 Sep 1, 2026
2a00c40
Make `ProjectConfig.bboxes_pcutoff`` a property rather than a field
deruyter92 Sep 1, 2026
2689d30
add xfail for `ProjectConfig.bboxes_pcutoff`
deruyter92 Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update docstring for DetectorModelConfig
  • Loading branch information
@deruyter92
deruyter92 committed Sep 1, 2026
commit 0f5330a577b64495b648c459fa0971616f199bbf
5 changes: 5 additions & 0 deletions deeplabcut/pose_estimation_pytorch/config/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ class DetectorModelConfig(DLCBaseConfig):
freeze_bn_stats: Whether to freeze batch normalization statistics
freeze_bn_weights: Whether to freeze batch normalization weights
variant: Specific variant of the detector model
box_score_thresh: The score below which the detector discards proposals
internally. ``null`` is normalized to the default. The value is
deliberately permissive, as raising this value silently drops
detections. Note the distinction with ``bboxes_pcutoff`` in the
project config, which is the cutoff used to *plot* bounding boxes.
"""

type: str = ""
Expand Down