Visitar URL original
`InferenceRunner` + `analyze_videos`: Fix top-down analysis crashing for zero-detections and unreadable video handling by deruyter92 · Pull Request #3488 · DeepLabCut/DeepLabCut · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
64a2f4e
fix _generate_output_data crash on empty predictions
deruyter92 Sep 8, 2026
510090e
Allow create_df_from_prediction() to handle an empty predictions list.
deruyter92 Sep 8, 2026
4b45fb9
Treat zero predictions as a distinct warning case in `video_inference()`
deruyter92 Sep 8, 2026
c78f439
Don't write dataframe for empty predictions
deruyter92 Sep 9, 2026
16a2977
update test_videos: pop `"PAFinds"` before comparison
deruyter92 Sep 9, 2026
f534de6
update test_videos: assert no DF is written for empty predictions
deruyter92 Sep 9, 2026
624b1b1
Return empty-detection inference results
C-Achard Sep 9, 2026
c57dd35
Use CTD predictions for video output
C-Achard Sep 9, 2026
4e4dab7
Handle empty prediction outputs gracefully
C-Achard Sep 9, 2026
42098ac
Reuse shared frame key width helper
C-Achard Sep 9, 2026
292d068
Clarify video inference warnings
C-Achard Sep 9, 2026
d5ba290
Go back to ValueError for empty predictions
C-Achard Sep 9, 2026
bff4fea
Remove NaN fallback for empty video predictions
C-Achard Sep 9, 2026
06486de
Fix CTD export guard for empty predictions
C-Achard Sep 9, 2026
e456aeb
Clarify empty CTD prediction handling
C-Achard Sep 9, 2026
a162439
Centralize test fakes
C-Achard Sep 9, 2026
11ff4fd
Add test for async with no images
C-Achard Sep 9, 2026
a210b69
Clarify async inference test comment
C-Achard Sep 9, 2026
c7a8c34
Use shared frame key width helper
C-Achard Sep 9, 2026
8248a10
Merge branch 'dev' into jaap/fix-empty-video-predictions
C-Achard Sep 17, 2026
90849a5
Don't write pickle for unreadable video
deruyter92 Oct 22, 2026
4b8c0ca
Video inference: update warning for empty predictions
deruyter92 Oct 22, 2026
44918dd
InferenceRunner: don't emit results for producer exceptions
deruyter92 Oct 22, 2026
0e40ba8
update code comment
deruyter92 Oct 22, 2026
b0fbd36
fix ShelfWriter: report zero framens when empty
deruyter92 Oct 22, 2026
ce627ae
Skip unreadable videos with shelf writer + improve docstring and log …
deruyter92 Oct 22, 2026
4867b92
Merge branch 'dev' into jaap/fix-empty-video-predictions
deruyter92 Oct 22, 2026
89d06d0
Fix warning typo + update tests
deruyter92 Oct 22, 2026
a67e257
Remove unreachable CTD empty-export branch and reword FMPose error
deruyter92 Oct 22, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Video inference: update warning for empty predictions
since #3488, all readable frames yield a prediction (even when no animal was detectied) an empty predictions means no readable frames.
  • Loading branch information
deruyter92 committed Oct 22, 2026
commit 4b8c0ca55162c41269f426111ad170a53a0d3b45
8 changes: 1 addition & 7 deletions deeplabcut/pose_estimation_pytorch/apis/videos.py
Original file line number Diff line number Diff line change
Expand Up @@ -237,14 +237,8 @@ def video_inference(
f"by re-encoding your video (tips on how to do that: {tip_url}{header})"
)
if len(predictions) == 0:
causes = (
"no animals were detected in any frame, or the video could not be read"
if detector_runner is not None
else "the video could not be read"
)
logging.warning(
f"No predictions were produced for {video.video_path}: {causes}. "
f"Check model performance if that is unexpected. {reencoding_tip}"
f"No predictions were produced for {video.video_path}: the video could not be read. {reencoding_tip}"
)
elif len(predictions) != n_frames:
logging.warning(
Expand Down
23 changes: 7 additions & 16 deletions tests/pose_estimation_pytorch/apis/test_videos.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,16 @@ def _pose_runner(predictions: list) -> Mock:
return runner


def test_video_inference_zero_predictions_warns_about_unreadable_video(patch_video_iterator, caplog):
"""Without a detector, every readable frame yields a prediction, so an empty
result means the video could not be read - not that no animals were found."""
@pytest.mark.parametrize("with_detector", [False, True])
def test_video_inference_zero_predictions_warns_about_unreadable_video(patch_video_iterator, caplog, with_detector):
"""Every readable frame yields a prediction (padded when no animal is detected),
so an empty result means the video could not be read - not that no animals were
found."""
patch_video_iterator(3)
detector_runner = _pose_runner([]) if with_detector else None

with caplog.at_level("WARNING"):
predictions = videos.video_inference("video.mp4", _pose_runner([]))
predictions = videos.video_inference("video.mp4", _pose_runner([]), detector_runner=detector_runner)

assert predictions == []
assert "No predictions were produced for video.mp4" in caplog.text
Expand All @@ -104,18 +107,6 @@ def test_video_inference_zero_predictions_warns_about_unreadable_video(patch_vid
assert "re-encoding your video" in caplog.text


def test_video_inference_zero_predictions_with_detector_warns_about_detections(patch_video_iterator, caplog):
patch_video_iterator(3)

with caplog.at_level("WARNING"):
predictions = videos.video_inference("video.mp4", _pose_runner([]), detector_runner=_pose_runner([]))

assert predictions == []
assert "no animals were detected in any frame" in caplog.text
assert "the video could not be read" in caplog.text
assert "re-encoding your video" in caplog.text


def test_video_inference_zero_predictions_warns_when_frame_count_is_zero(patch_video_iterator, caplog):
"""A video whose metadata reports 0 frames must still warn."""
patch_video_iterator(0)
Expand Down