Visitar URL original
Route GUI Qt imports through qtpy, keeping PySide6 preferred by C-Achard · Pull Request #3490 · DeepLabCut/DeepLabCut · GitHub
Skip to content

Route GUI Qt imports through qtpy, keeping PySide6 preferred #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
C-Achard wants to merge 16 commits into
base: dev
Choose a base branch
from
Draft

Route GUI Qt imports through qtpy, keeping PySide6 preferred #3490

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f08fe7f
Add qtpy to pyproject.toml
C-Achard Sep 7, 2026
edd8a19
Change PySide6 imports for qtpy
C-Achard Sep 7, 2026
bc8f1d1
Improve GUI Qt binding selection
C-Achard Sep 7, 2026
f28174d
Improve GUI Qt binding import error message
C-Achard Sep 7, 2026
13dff38
Use matplotlib qtagg backend in GUI
C-Achard Sep 7, 2026
42c9acb
Avoid QT_API override in darkstyle loading
C-Achard Sep 7, 2026
25fe8cd
Update Qt app exec call
C-Achard Sep 7, 2026
12ff06a
Guard the GUI entry point against binding selection failures
C-Achard Sep 7, 2026
6a805f1
Remove incorrect comment
C-Achard Sep 7, 2026
0c45373
Update uv.lock
C-Achard Sep 8, 2026
a419a77
Import actual qt object imported by dlc instead of global
C-Achard Sep 8, 2026
73ac997
Update tests to use qtpy
C-Achard Sep 8, 2026
95db17c
Remove user-facing GPL Qt binding warning
C-Achard Sep 8, 2026
986a612
Raise the matplotlib floor to 3.5
C-Achard Sep 8, 2026
f247da8
Use exec_ for GUI app startup
C-Achard Sep 8, 2026
bceedc0
Exit CLI on GUI import failures
C-Achard Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid QT_API override in darkstyle loading 
Switch GUI dark theme setup to `qdarkstyle.load_stylesheet(palette=DarkPalette)` in both app launch and the runtime dark mode toggle. This avoids the binding-specific helpers that mutate `QT_API` and can desynchronize matplotlib from qtpy’s loaded backend. Also keep the bundled `style.qss` as a fallback if qdarkstyle fails to load, with clearer warning logging.
  • Loading branch information
@C-Achard
C-Achard committed Sep 7, 2026
commit 42c9acbc62bd05d837188bc7a503bb9a5d41da04
14 changes: 8 additions & 6 deletions deeplabcut/gui/launch_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import sys

import qdarkstyle
from qdarkstyle.dark.palette import DarkPalette
from qtpy import QtWidgets
from qtpy.QtCore import Qt

Expand All @@ -39,13 +40,14 @@ def launch_dlc():
splash = QtWidgets.QSplashScreen(pixmap)
splash.show()

app.setStyleSheet(get_style_qss()) # this gets overridden immediately?
app.setStyleSheet(get_style_qss())
try:
dark_stylesheet = qdarkstyle.load_stylesheet_pyside6()
except Exception as e:
logger.warning(f"Could not load qdarkstyle stylesheet for PySide6: {e}. Falling back to PySide2 stylesheet.")
dark_stylesheet = qdarkstyle.load_stylesheet_pyside2()
app.setStyleSheet(dark_stylesheet)
# Always pass `palette=`: the zero-argument load_stylesheet() and the
# load_stylesheet_<binding>() helpers overwrite os.environ["QT_API"],
# which desynchronises matplotlib from the binding qtpy loaded.
app.setStyleSheet(qdarkstyle.load_stylesheet(palette=DarkPalette))
except Exception:
logger.warning("Could not load the qdarkstyle stylesheet; keeping the bundled style.qss.", exc_info=True)

# Set up a logger and add an stdout handler.
# A single logger can have many handlers:
Expand Down
4 changes: 3 additions & 1 deletion deeplabcut/gui/window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,7 +1234,9 @@ def load_config(
return True

def darkmode(self):
dark_stylesheet = qdarkstyle.load_stylesheet_pyside2()
from qdarkstyle.dark.palette import DarkPalette

dark_stylesheet = qdarkstyle.load_stylesheet(palette=DarkPalette)
self.app.setStyleSheet(dark_stylesheet)

names = ["new_project2.png", "open2.png", "help2.png"]
Expand Down