Repository navigation
Validated pydantic 3D project configs ProjectConfig3D - #3589
Draft
deruyter92 wants to merge 3 commits into
Draft
deruyter92 wants to merge 3 commits into
deruyter92 wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validated 3D project configs (
ProjectConfig3D)Fixes #3585. Builds on #3587 (its two commits are included; rebase drops them if #3587 merges first).
Summary
The config loading of 3D projects was mixed with that of 2D projects, which introduced validation errors since 3.0.1, when validated configs were introduced for 2D projects. (A regression bug, described in #3585 and fixed in #3587). This PR builds on top of that fix and introduces validated pydantic 3D project configurations for 3D projects, similar to
ProjectConfig.Changes
ProjectConfig3D/CameraConfig3D: Note that the model uses a slightly different layout than what is on-disk. Per-camera settings are grouped incameras[name], ensuring fixed top-level fields. The on-disk yaml layout is unchanged (top-level yaml keys depend on the camera name).calibrate_camerasis removed, as it is not necessary anymore (it renamedconfig_file_camera-<i>/shuffle_camera-<i>to the user's camera names, but nottrainingsetindex_)create_config_template_3d/write_config_3dare no longer used internally but still exported; deprecation left for a separate PR.