Visitar URL original
Release numpy<2 pin by C-Achard · Pull Request #241 · DeepLabCut/napari-deeplabcut · GitHub
Skip to content

Release numpy<2 pin - #241

Merged
C-Achard merged 3 commits into
mainfrom
cy/release-np-pin
Sep 15, 2026
Merged

C-Achard merged 3 commits into
mainfrom
cy/release-np-pin

Conversation

@C-Achard

@C-Achard C-Achard commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Following efforts to release upper bounds on several packages (see DeepLabCut/DeepLabCut#3499), removes the numpy upper bound on the pugin.

  • Bump uv lock
  • Add CI workflow to check uv lock is current

@C-Achard
C-Achard requested a lite review from Copilot September 11, 2026 08:49
@C-Achard C-Achard self-assigned this Sep 11, 2026
@C-Achard C-Achard added the dependencies Related to project dependencies label Sep 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Regenerate uv.lock to match the updated dependency constraint.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Removes the NumPy <2 upper bound from the plugin dependency.

Changes:

  • Updates the requirement to numpy>=1.18.5.
File summaries
File Description
pyproject.toml Relaxes the NumPy dependency constraint.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pyproject.toml Resolved
Add a GitHub Actions workflow that runs on pushes to `main` and pull requests when `pyproject.toml`, `uv.lock`, or the workflow file changes. It sets up Python and `uv`, then runs `uv lock --check` to ensure the committed lockfile stays in sync with dependency changes.
@C-Achard
C-Achard marked this pull request as ready for review September 11, 2026 09:02
@C-Achard
C-Achard requested a lite review from Copilot September 11, 2026 10:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All reviewed changes are complete with no unresolved review comments.

Review details
  • Files reviewed: 2/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@C-Achard
C-Achard requested a review from deruyter92 September 14, 2026 12:08
@C-Achard
C-Achard merged commit 038e03a into main Sep 15, 2026
14 checks passed
@C-Achard
C-Achard deleted the cy/release-np-pin branch September 15, 2026 11:55
@C-Achard C-Achard added the 0.3.2 label Sep 17, 2026
@C-Achard C-Achard added this to the 0.4.0 milestone Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related to project dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants