Visitar URL original
Update deps by grahamc · Pull Request #259 · DeterminateSystems/update-flake-lock · GitHub
Skip to content

Update deps - #259

Merged
grahamc merged 6 commits into
mainfrom
push-ytxzrzukyqur
Mar 25, 2026
Merged

grahamc merged 6 commits into
mainfrom
push-ytxzrzukyqur

Conversation

@grahamc

@grahamc grahamc commented Mar 25, 2026 •

Copy link
Copy Markdown
Member
Description
Checklist
  • Tested functionality against a test repository (see "How to test changes")
  • Added or updated relevant documentation (leave unchecked if not applicable)

Summary by CodeRabbit

  • Chores

    • Updated workflow examples to use checkout v6 across documented scenarios
    • Bumped core runtime dependencies to newer major versions
    • Updated build configuration for Node 24 compatibility
    • Enabled build execution for additional workspace tools
  • Documentation

    • Revised workflow example docs to reflect the checkout update

@coderabbitai

coderabbitai Bot commented Mar 25, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ccb8ee3d-f5cf-4adf-9a6a-234da928a92f

📥 Commits

Reviewing files that changed from the base of the PR and between dac257e and f1a2ee7.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • package.json

📝 Walkthrough

Walkthrough

Updated README workflow examples to use actions/checkout@v6; bumped GitHub Actions runtime dependencies in package.json; added a dev dependency parser; added allowBuilds entries in pnpm-workspace.yaml; and changed tsup build target from Node 20 to Node 24.

Changes

Cohort / File(s) Summary
Documentation
README.md
Replaced actions/checkout@v4 with actions/checkout@v6 across all workflow examples and job variants.
Dependencies
package.json
Bumped @actions/core and @actions/exec to ^3.0.0; added @typescript-eslint/parser@^7.18.0 to devDependencies.
Workspace / Build config
pnpm-workspace.yaml, tsup.config.ts
Added allowBuilds entries for esbuild and unrs-resolver in pnpm workspace; changed tsup target from "node20" to "node24".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • lucperkins

Poem

"i'm a rabbit with a changelog hat,
checkout hopped to six — imagine that!
deps got nudged and builds grew tall,
node twenty-four now leads the ball.
sniff, nibble, merge — a joyful spat 🐇"

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update deps' is vague and generic, failing to convey meaningful information about the specific changes made in the changeset. Use a more descriptive title that captures the main changes, such as 'Update GitHub Actions checkout to v6 and bump core/exec dependencies' or 'Bump dependencies and update Node.js target to 24'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch push-ytxzrzukyqur

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 34: package.json now includes the `@eslint/js` dependency but the repo
still uses the legacy .eslintrc.json config; either remove the `@eslint/js` entry
from package.json if you want to keep legacy config, or migrate to ESLint's flat
config by deleting .eslintrc.json, adding an eslint.config.js (or .mjs) file
that imports/uses "@eslint/js" and re-exports the flat config, and update any
npm scripts that invoke eslint if necessary; locate package.json,
.eslintrc.json, and create eslint.config.js to implement the chosen option.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eba56e80-2fe5-4fe7-b1db-f81b8fce2ef8

📥 Commits

Reviewing files that changed from the base of the PR and between 5070bce and dac257e.

⛔ Files ignored due to path filters (2)
  • dist/index.js is excluded by !**/dist/**
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • README.md
  • package.json
  • pnpm-workspace.yaml
  • tsup.config.ts

Comment thread package.json Resolved
@grahamc
grahamc merged commit 492ddbf into main Mar 25, 2026
3 checks passed
@grahamc
grahamc deleted the push-ytxzrzukyqur branch March 25, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants