Repository navigation
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Points Blitz at a Stylo branch (DioxusLabs/stylo
enable-svg-properties-servo) that makes the SVG properties Stylo still gated to Gecko available to Servo builds behind a newlayout.css.svg-properties.enabledpref, and turns that pref on ininit_stylo_prefs. The properties arestop-color,stop-opacity,paint-order,marker-start/-mid/-endand themarkershorthand,clip-rule,text-anchor,vector-effect,transform-box,flood-color,flood-opacity,lighting-color,color-interpolation,color-interpolation-filters,shape-renderingand-moz-context-properties. This is milestone 0 of native SVG rendering: these properties now parse and cascade, so SVG paint code can read them from computed styles instead of from attributes.The Stylo change removes
engine = "gecko"from those properties, addsservo_pref = "layout.css.svg-properties.enabled"(defaultfalse), and removes thecfg(gecko)on themarkershorthand's parse/serialize code. It's meant to go upstream to servo/stylo. The[patch.crates-io]block pins that commit, like #1098, and should be removed once the change is in a Stylo release.Nothing in Blitz reads these properties yet, so rendering should be unchanged. Any WPT diff should come from parsing/computed-value tests for these properties.
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/4ffac007d4984409a3915d7477fb3d74
Link to Bot: https://dioxus.staging.devinenterprise.com/org/dioxus-engineering/bots/3904245e951a4a7fa4631b37b308d89b
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/4ffac007d4984409a3915d7477fb3d74?variant=devin-insiders
Painting opened this PR for Nico
Implemented in Un-gate gecko-only SVG properties in stylo · Review with Devin
WPT results
Subtests: 369 newly passing, 0 newly failing (net +369).
Subtest changes by area (22 areas)
Full diff (50 changed tests)
Generated by the WPT workflow.