Repository navigation
Restore frontend router after loading member form libraries - #5350
Open
robinsowell wants to merge 1 commit into
Open
robinsowell wants to merge 1 commit into
robinsowell wants to merge 1 commit into
Conversation
Prevent member edit and registration tags from leaving the router in the control panel context, which can break subsequent frontend layout parsing. Add regression coverage for both forms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent member edit and registration tags from leaving the router in the control panel context, which can break subsequent frontend layout parsing. Add regression coverage for both forms.
Why this matters
The router is shared for the entire request. These frontend Member tags temporarily change it to
cpso they can load Control Panel form libraries:{exp:member:edit_profile}{exp:member:registration_form}Previously, they never changed it back. Anything parsed after the tag could therefore incorrectly believe it was running inside the Control Panel.
For example:
After rendering the member form, ExpressionEngine still reported the router class as cp. This could interfere with subsequent layout and template processing, especially on an MSM installation.
Observed symptoms included:
Nested layouts failing with Template Not Found, resulting in a blank page.
Site-specific template variables remaining unparsed, such as:
{var_licenses-table_styles_2024}