Visitar URL original
Fixed database backups failing on JSON columns by TomJaeger · Pull Request #5436 · ExpressionEngine/ExpressionEngine · GitHub
Skip to content

Fixed database backups failing on JSON columns - #5436

Open
TomJaeger wants to merge 1 commit into
7.devfrom
fix/database-backup-json
Open

TomJaeger wants to merge 1 commit into
7.devfrom
fix/database-backup-json

Conversation

@TomJaeger

Copy link
Copy Markdown
Contributor

Database backups fail with Non-existant column requested when exporting a populated table with a native JSON column. Recognize json as a string type so its values use the existing SQL escaping path while preserving SQL NULL.

Adds regression coverage for a JSON document containing an apostrophe and backslash, numeric JSON, JSON null, and SQL NULL.

Validation:

  • Confirmed the regression test fails before the fix and passes afterward.
  • Backup service tests pass on PHP 7.4, 8.2, and 8.5: 4 tests and 13 assertions on each runtime.
  • PHP syntax checks and git diff --check pass. Independent review found no actionable issues.

A live MySQL backup/restore round trip was not run.

@TomJaeger TomJaeger added the Bug: Accepted Bug has been confirmed, is reproducible, and ready to work on. label Oct 23, 2026
@albuvee

albuvee commented Oct 23, 2026

Copy link
Copy Markdown

LGTM! Works like a charm 🚀 Thank you! 😊

@TomJaeger TomJaeger added this to the 7.5.29 milestone Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug: Accepted Bug has been confirmed, is reproducible, and ready to work on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants