Visitar URL original
Footer column layout bug by nick-mon1 · Pull Request #7271 · GSA/digitalgov.gov · GitHub
Skip to content
This repository was archived by the owner on Dec 29, 2025. It is now read-only.

Footer column layout bug - #7271

Closed
nick-mon1 wants to merge 1 commit into
mainfrom
nl-footer-layout-bug
Closed

Footer column layout bug#7271
nick-mon1 wants to merge 1 commit into
mainfrom
nl-footer-layout-bug

Conversation

@nick-mon1

@nick-mon1 nick-mon1 commented Feb 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Footer grid styles are overridden on desktop causing mobile grid styles to be applied on desktop viewport.
Mobile styles are fine.

Note

See uswds/uswds#5289 for details about footer style changes

Screenshots Screen Shot 2024-02-05 at 4 39 36 PM Screen Shot 2024-02-05 at 4 39 44 PM

styles.css

Stylesheet order is correct.

@forward "usa-footer/src/styles";
...
@forward "usa-layout-grid/src/styles";

Expected

@media (min-width: 55em) {
  .tablet-lg\:grid-col-3
{
    flex: 0 1 auto;
    width: 25%;
  }
}

Actual

@media (min-width: 30em) {
  .usa-footer .grid-row .mobile-lg\:grid-col-6
{
    flex: 0 1 auto;
    width: 50%;
  }
}

Preview

Wayback Machine

Solution

How To Test

  1. view preview
  2. Styles are being applied out of order on desktop

@github-actions

github-actions Bot commented Feb 5, 2024

Copy link
Copy Markdown

🔍 Preview in Federalist

@nick-mon1 nick-mon1 assigned clmedders and nick-mon1 and unassigned clmedders Feb 5, 2024
@mejiaj

mejiaj commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

@nick-mon1 should we close this in favor of #7278?

@nick-mon1

nick-mon1 commented Feb 9, 2024

Copy link
Copy Markdown
Contributor Author

@mejiaj Good call.

@nick-mon1 nick-mon1 closed this Feb 9, 2024
@mejiaj
mejiaj deleted the nl-footer-layout-bug branch February 9, 2024 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@nick-mon1 nick-mon1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nick-mon1 @mejiaj @clmedders