Visitar URL original
Compile widget after382 by ryanwoldatwork · Pull Request #1549 · GSA/touchpoints · GitHub
Skip to content

Compile widget after382 - #1549

Merged
ryanwoldatwork merged 4 commits into
developfrom
compileWidgetAfter382
Aug 22, 2024
Merged

Compile widget after382#1549
ryanwoldatwork merged 4 commits into
developfrom
compileWidgetAfter382

Conversation

@ryanwoldatwork

@ryanwoldatwork ryanwoldatwork commented Aug 16, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@ryanwoldatwork
ryanwoldatwork requested a review from sanason August 16, 2024 04:17
sanason
sanason reviewed Aug 16, 2024
View reviewed changes

@sanason sanason left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the USWDS assets used by the Touchpoints app (run npx gulp updateUswds)?

@ryanwoldatwork

ryanwoldatwork commented Aug 16, 2024

Copy link
Copy Markdown
Contributor Author

ya, if there's a conventional way to run the tasks

@sanason

sanason commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

npx gulp updateUswds updates the assets for the Touchpoints app.

https://github.com/GSA/touchpoints/wiki/Developer-Guide#updating-uswds

sanason
sanason requested changes Aug 21, 2024
View reviewed changes

@sanason sanason left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'll cause confusion if we don't update both the app and widget when we upgrade the USWDS version.

https://github.com/GSA/touchpoints/wiki/Developer-Guide#updating-uswds

@ryanwoldatwork

ryanwoldatwork commented Aug 21, 2024

Copy link
Copy Markdown
Contributor Author

I added a npm script updateUswds to run all the commands.

Doing so yielded the following diff.
But it looks like that can all be ignored. Thoughts?

fsddsfsdasfdfsa

sanason
sanason approved these changes Aug 22, 2024
View reviewed changes

@sanason sanason left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ryanwoldatwork
ryanwoldatwork merged commit ec6495d into develop Aug 22, 2024
@ryanwoldatwork
ryanwoldatwork deleted the compileWidgetAfter382 branch August 22, 2024 15:17
@sanason

sanason commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

Doing so yielded the following diff. But it looks like that can all be ignored. Thoughts?

Yes, agreed. In particular, I have a USWDS PR out to prevent the changes in _widget-uswds.js.erb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanason sanason sanason approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryanwoldatwork @sanason