Repository navigation
Add CSS to fix alert icons - #457
Closed
Jeremy1026 wants to merge 2 commits into
Closed
Jeremy1026 wants to merge 2 commits into
Jeremy1026 wants to merge 2 commits into
Conversation
Contributor
|
This bug is fixed in newer versions of the design system, can we update instead? Specifically: Upgrading to at least |
Contributor
Author
|
Cancelling this PR because updating the design system and build-sass worked! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the icons in the warning boxes. Currently the CSS on the
beforepseudo element has the stylesWith
height: 2pxtaking precedent over theheight: 1rem. I'm re-adding theheight: 1remwith higher precedent to "win."I know we don't like to add CSS directly, but I can not find where the
height: 2pxis being added to the element's style.Before:
After: