Visitar URL original
[Asset] Add requirements.txt by peter-zheng-g · Pull Request #1834 · GoogleCloudPlatform/python-docs-samples · GitHub
Skip to content

[Asset] Add requirements.txt - #1834

Merged
gguuss merged 19 commits into
GoogleCloudPlatform:masterfrom
peter-zheng-g:master
Nov 13, 2018
Merged

[Asset] Add requirements.txt#1834
gguuss merged 19 commits into
GoogleCloudPlatform:masterfrom
peter-zheng-g:master

Conversation

@peter-zheng-g

@peter-zheng-g peter-zheng-g commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2018
gguuss
gguuss suggested changes Nov 13, 2018
View reviewed changes

@gguuss gguuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I missed in the initial review. Sorry for that, let's take another look tomorrow morning before my meetings.

Comment thread asset/cloud-client/requirements.txt Resolved
gguuss
gguuss reviewed Nov 13, 2018
View reviewed changes
Comment thread asset/cloud-client/quickstart_exportassets_test.py Resolved
@peter-zheng-g

peter-zheng-g commented Nov 13, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!

@gguuss

gguuss commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

Please update the branch.

gguuss
gguuss suggested changes Nov 13, 2018
View reviewed changes
Comment thread asset/cloud-client/quickstart_exportassets.py Resolved
Comment thread asset/cloud-client/quickstart_exportassets_test.py Resolved
gguuss
gguuss reviewed Nov 13, 2018
View reviewed changes
Comment thread asset/cloud-client/quickstart_exportassets_test.py
except Exception:
pass
except Exception as e:
print('Failed to delete bucket{}'.format(BUCKET))

@gguuss gguuss Nov 13, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space between bucket and {}:

print('Failed to delete bucket: {}'.format(BUCKET))

gguuss
gguuss approved these changes Nov 13, 2018
View reviewed changes

@gguuss gguuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, consider cleaning up your formatting on the exception in the test.

@gguuss
gguuss merged commit 1d868fb into GoogleCloudPlatform:master Nov 13, 2018
arithmetic1728 pushed a commit to googleapis/python-asset that referenced this pull request Jul 31, 2020
@peter-zheng-g @gguuss
[Asset] Add requirements.txt [(#1834)](GoogleCloudPlatform/python-doc…
36a7825 
…s-samples#1834)

Adds asset quickstart
busunkim96 pushed a commit to googleapis/python-asset that referenced this pull request Aug 4, 2020
@peter-zheng-g @busunkim96
[Asset] Add requirements.txt [(#1834)](GoogleCloudPlatform/python-doc…
641c48c 
…s-samples#1834)

Adds asset quickstart
engelke pushed a commit that referenced this pull request Nov 28, 2022
@peter-zheng-g @busunkim96
[Asset] Add requirements.txt [(#1834)](#1834)
c573eab 
Adds asset quickstart
dandhlee pushed a commit that referenced this pull request Nov 29, 2022
@peter-zheng-g @dandhlee
[Asset] Add requirements.txt [(#1834)](#1834)
dba0389 
Adds asset quickstart
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
@peter-zheng-g @busunkim96
[Asset] Add requirements.txt [(#1834)](GoogleCloudPlatform/python-doc…
7eec591 
…s-samples#1834)

Adds asset quickstart
@parthea parthea mentioned this pull request Sep 8, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gguuss gguuss gguuss approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peter-zheng-g @gguuss @googlebot