Visitar URL original
automl: video beta move model samples from branch to master by nnegrey · Pull Request #2754 · GoogleCloudPlatform/python-docs-samples · GitHub
Skip to content

automl: video beta move model samples from branch to master - #2754

Merged
leahecole merged 6 commits into
masterfrom
automl-video-beta-model
Jan 31, 2020
Merged

automl: video beta move model samples from branch to master#2754
leahecole merged 6 commits into
masterfrom
automl-video-beta-model

Conversation

@nnegrey

@nnegrey nnegrey commented Jan 29, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2020
@nnegrey
nnegrey marked this pull request as ready for review January 29, 2020 17:03
@nnegrey
nnegrey requested a review from a team as a code owner January 29, 2020 17:03
leahecole
leahecole requested changes Jan 29, 2020
View reviewed changes

@leahecole leahecole left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good, but I'd like to propose either

  • moving them into a subdirectory in beta called video
    OR
  • prefixing the filenames with video_, like we do for language and vision in the cloud-client folder

Or, if y'all ML APIs folks have something you prefer in general that isn't one of those two things but still helps differentiate, I'm game for that too

Unless this isn't strictly video specific, in which case, they're great.

Comment thread automl/beta/delete_model_test.py Resolved
Comment thread automl/beta/get_model_evaluation_test.py Resolved
@nnegrey

nnegrey commented Jan 29, 2020

Copy link
Copy Markdown
Contributor Author

So while these samples are for the video beta, the samples can be used with any automl product.

The samples that are only for video can be found on this PR and those have the video_ prefix.
#2750

@nnegrey

nnegrey commented Jan 29, 2020

Copy link
Copy Markdown
Contributor Author

But I did miss some _beta on the region tags

@leahecole
leahecole merged commit 027f0e5 into master Jan 31, 2020
@leahecole
leahecole deleted the automl-video-beta-model branch January 31, 2020 22:02
busunkim96 pushed a commit to busunkim96/python-automl that referenced this pull request Aug 7, 2020
@nnegrey @leahecole
automl: video beta move model samples from branch to master [(#2754)](G…
85252e7 
…oogleCloudPlatform/python-docs-samples#2754)

* automl: video beta move model samples from branch to master

* Fix region tag

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96 pushed a commit to googleapis/python-automl that referenced this pull request Aug 13, 2020
@nnegrey @leahecole @busunkim96
automl: video beta move model samples from branch to master [(#2754)](G…
34cb1b4 
…oogleCloudPlatform/python-docs-samples#2754)

* automl: video beta move model samples from branch to master

* Fix region tag

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
arbrown pushed a commit that referenced this pull request Nov 17, 2022
@nnegrey @leahecole @busunkim96
automl: video beta move model samples from branch to master [(#2754)](#…
67e0111 
…2754)

* automl: video beta move model samples from branch to master

* Fix region tag

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@arbrown arbrown mentioned this pull request Nov 17, 2022
Merged
8 tasks
dandhlee pushed a commit that referenced this pull request Nov 17, 2022
@nnegrey @leahecole @dandhlee
automl: video beta move model samples from branch to master [(#2754)](#…
d15c914 
…2754)

* automl: video beta move model samples from branch to master

* Fix region tag

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
@nnegrey @leahecole @busunkim96
automl: video beta move model samples from branch to master [(#2754)](G…
5d605e4 
…oogleCloudPlatform/python-docs-samples#2754)

* automl: video beta move model samples from branch to master

* Fix region tag

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leahecole leahecole leahecole approved these changes

Assignees

@leahecole leahecole

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nnegrey @leahecole @googlebot