Repository navigation
Fix stiff rod corrections with multiple static segments - #207
Open
JianP-Ciallo wants to merge 1 commit into
Open
JianP-Ciallo wants to merge 1 commit into
JianP-Ciallo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The direct stiff rod solver stops writing position and orientation corrections when its forward traversal reaches a static segment. In a three-segment rod with both ends fixed, the traversal visits the static leaf first, so the middle dynamic segment receives no correction.
Skip static segments and continue updating the remaining segments. Add an opt-in CTest regression using the public solver API, covering translation and twist with all segments dynamic, one fixed end, and two fixed ends.
Fixes #79.
Validation:
-O0, libstdc++ debug assertions) and Release (-O3 -DNDEBUG).Validation scope: Windows MinGW. The full interactive demo build, MSVC and Linux/macOS builds have not been run.