Visitar URL original
feat: Capture expression name part delimiters by mountaincrab · Pull Request #2001 · JSQLParser/JSqlParser · GitHub
Skip to content

feat: Capture expression name part delimiters #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 5 commits into from
May 3, 2024
Merged

feat: Capture expression name part delimiters #2001

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d57096
feat: Capture expression name part delimiters
mountaincrab May 2, 2024
82992ff
feat: Checkstyle
mountaincrab May 2, 2024
4df076a
feat: Test for empty name parts
mountaincrab May 3, 2024
12fe46e
feat: Move ObjectNames class to parser. Tidy imports.
mountaincrab May 3, 2024
90bd42e
feat: Spotless
mountaincrab May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: Test for empty name parts
  • Loading branch information
@mountaincrab
mountaincrab committed May 3, 2024
commit 4df076afd97a77bc8d085c5ba1c131a5e41b9016
2 changes: 1 addition & 1 deletion src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1894,7 +1894,7 @@ ObjectNames RelObjectNames() : {
} {
token = RelObjectNameExt() { data.add(token); }
(
LOOKAHEAD (2) ( delimiter = "." | delimiter = ":" ) { delimiters.add(delimiter.image); } ( delimiter = "." { data.add(null); delimiters.add(delimiter.image); })*
LOOKAHEAD (2) ( delimiter = "." | delimiter = ":" ) { delimiters.add(delimiter.image); } (( delimiter = "." | delimiter = ":" ) { data.add(null); delimiters.add(delimiter.image); })*
token = RelObjectNameExt2() { data.add(token); }
) *

Expand Down
10 changes: 10 additions & 0 deletions src/test/java/net/sf/jsqlparser/statement/select/ExpressionDelimiterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

import net.sf.jsqlparser.JSQLParserException;
import net.sf.jsqlparser.schema.Column;
import net.sf.jsqlparser.schema.Table;
import org.junit.jupiter.api.Test;

import java.util.List;
Expand All @@ -28,4 +29,13 @@ public void testColumnWithDifferentDelimiters() throws JSQLParserException {
assertEquals(":", column.getTableDelimiter());
assertEquals(List.of(":", "."), column.getTable().getNamePartDelimiters());
}

@Test
public void testColumnWithEmptyNameParts() throws JSQLParserException {
String statement = "SELECT mytable.:.child FROM mytable";
PlainSelect parsed = (PlainSelect) assertSqlCanBeParsedAndDeparsed(statement);
Column column = parsed.getSelectItem(0).getExpression(Column.class);
assertEquals(".", column.getTableDelimiter());
assertEquals(List.of(":", "."), column.getTable().getNamePartDelimiters());
}
}