Visitar URL original
Complete traversal of structured DDL children by minleejae · Pull Request #2738 · JSQLParser/JSqlParser · GitHub
Skip to content

Complete traversal of structured DDL children #2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 3 commits into from
Oct 11, 2026
Merged

Complete traversal of structured DDL children #2738

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fe759a
fix: complete traversal of structured DDL children
minleejae Oct 1, 2026
7f8bb7f
test: cover VALUES child traversal with context
minleejae Oct 1, 2026
c13f7ee
Merge upstream/master into refactor/ddl-visitors-20261001
minleejae Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: cover VALUES child traversal with context 
Signed-off-by: minleejae <mmj9808@gmail.com>
  • Loading branch information
@minleejae
minleejae committed Oct 1, 2026
commit 7f8bb7fb24401a4940ff89d36aefa8e224603c08
22 changes: 21 additions & 1 deletion src/test/java/net/sf/jsqlparser/statement/DdlVisitorTraversalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import net.sf.jsqlparser.util.deparser.StatementDeParser;
import net.sf.jsqlparser.util.validation.Validation;
import net.sf.jsqlparser.util.validation.feature.FeaturesAllowed;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
Expand Down Expand Up @@ -62,6 +63,25 @@ static Stream<Arguments> definitions() {
List.of("7", "9", "before"), List.of("t", "log")));
}

@Test
void valuesChildrenIncludingWithAndTailKeepTheVisitorContext() throws Exception {
Object context = new Object();
List<Long> values = new ArrayList<>();
ExpressionVisitorAdapter<Void> expressions = new ExpressionVisitorAdapter<Void>() {
@Override
public <S> Void visit(LongValue value, S actualContext) {
assertSame(context, actualContext);
values.add(value.getValue());
return null;
}
};
Statement statement = CCJSqlParserUtil.parse(
"WITH c AS (SELECT 11) VALUES (22) ORDER BY (33 + 0) LIMIT 44 OFFSET 55");
statement.accept(new StatementVisitorAdapter<>(new SelectVisitorAdapter<>(expressions)),
context);
assertEquals(List.of(11L, 22L, 33L, 0L, 44L, 55L), values);
}

@ParameterizedTest
@MethodSource("definitions")
void visitsAndMutatesChildrenWithContext(String sql, List<String> expectedValues,
Expand Down Expand Up @@ -97,7 +117,7 @@ public <S> Void visit(Table table, S actualContext) {
}
};
SelectVisitorAdapter<Void> selects =
new SelectVisitorAdapter<>(expressions, null, null, fromItems);
new SelectVisitorAdapter<>(expressions, fromItems);
statement.accept(new StatementVisitorAdapter<>(selects), context);
assertEquals(expectedValues, values);
assertEquals(expectedTables, tables);
Expand Down
Loading