feat(settings): sign in with a Claude account from the browser; CI green on the public repo - #25

🏁 Script executed:

sed -n '178,202p' .github/workflows/ci.yml
rg -n 'gitleaks-action|actions/checkout' .github/workflows

Repository: Jita81/commit-replay-bench

Length of output: 2467

🌐 Web query:

GitHub Actions Node 20 removal September 16 2026 actions fail Node 20 gitleaks-action v2 v3

💡 Result:

<search_synthesis>
The removal of Node.js 20 from GitHub Actions runners is scheduled for September 23, 2026, following a revision to the original September 16, 2026 timeline [1][2]. Regarding gitleaks-action, versions v2 and below utilize the Node 20 runtime and are incompatible with the transition to Node 24 [3][4]. To ensure continued functionality, you must upgrade to gitleaks-action v3, which has been explicitly migrated to the Node 24 runtime [3][5]. Key details regarding this transition include: 1. Deprecation Status: Node 20 reached end-of-life in April 2026, and GitHub has phased out its support in favor of Node 24 for JavaScript actions [1][6][7]. 2. Enforcement Date: While initial announcements targeted September 16, 2026, the final removal date for Node 20 from GitHub-hosted runners has been updated to September 23, 2026 [1][2]. Actions relying on Node 20 after this date will fail [2][4]. 3. Migration Action: You should update your workflow files to use gitleaks-action@v3 instead of v2 [3][5]. This is a direct replacement with no changes to inputs, outputs, or internal behavior [3][4]. 4. Opt-out: While environment variables like ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true were previously available to extend the use of Node 20, these are temporary workarounds and will no longer be effective once Node 20 is removed from the runners on September 23, 2026 [1][2][4]. For self-hosted runners, ensure your runner software is updated to at least v2.327.1 to support the Node 24 runtime required by v3 actions [3][8].
</search_synthesis>

<source_evidence>

Citations:

• 1: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
• 2: https://dotnetcoder.com/github-actions-node-js-20-removal-audit/
• 3: https://github.com/gitleaks/gitleaks-action/releases/tag/v3.0.0
• 4: GitHub issue 218 in gitleaks/gitleaks-action (link omitted to avoid creating a cross-reference)
• 5: https://github.com/gitleaks/gitleaks-action
• 6: GitHub pull request 4242 in actions/runner (link omitted to avoid creating a cross-reference)
• 7: GitHub issue 14029 in actions/runner-images (link omitted to avoid creating a cross-reference)
• 8: https://github.com/gitleaks/gitleaks-action/releases

🏁 Script executed:

#!/bin/bash
printf '%s\n' '--- workflow context ---'
sed -n '178,198p' .github/workflows/ci.yml
printf '%s\n' '--- local action/runtime references ---'
rg -n -i 'checkout@v[0-9]+|gitleaks-action|node20|node24|ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION|FORCE_JAVASCRIPT_ACTIONS_TO_NODE24' .github . 2>/dev/null | head -160

Repository: Jita81/commit-replay-bench

Length of output: 2283

🌐 Web query:

site:github.com/actions/checkout v4 v5 v6 action.yml runs using node20 node24 official

💡 Result:

<search_synthesis>
In GitHub Actions, the runs: using field in an action.yml file specifies the Node.js runtime required to execute the action&#39;s code [1][2]. The support for specific Node.js runtimes is tightly coupled to the version of the GitHub Actions Runner installed on the host machine [3][4]. 1. Node.js 24 Support: - The node24 runtime is supported starting with GitHub Actions Runner version v2.327.1 [3][5][4]. - Official actions, such as actions/checkout@v5 and newer, have been updated to use node24 [6][5][2]. - If you attempt to use an action configured with runs: using: node24 on a runner older than v2.327.1, the job will fail with an error stating that the node24 runtime is not supported [3][4]. 2. Node.js 20 Support: - The node20 runtime is supported on GitHub Actions Runner versions v2.308.0 and later [1]. Actions configured with node20 (such as actions/checkout@v4) will fail on older runner versions that only support up to node16 [1]. 3. Version Compatibility Summary: - Actions/Checkout v5 and v6: These versions use node24 and require a minimum Actions Runner version of v2.327.1 [6][7]. - Actions/Checkout v4: This version uses node20 and requires a minimum Actions Runner version of v2.308.0 [1]. To resolve errors related to unsupported runtimes (e.g., "Parameter &#39;using: node24&#39; is not supported"), you must upgrade your self-hosted runners to at least version v2.327.1 [3][4]. GitHub-hosted runners are managed by GitHub and are automatically updated to support newer Node.js runtimes [3].
</search_synthesis>

<source_evidence>

Citations:

• 1: GitHub issue 1667 in actions/checkout (link omitted to avoid creating a cross-reference)
• 2: actions/checkout@08eba0b...08c6903
• 3: GitHub issue 2240 in actions/checkout (link omitted to avoid creating a cross-reference)
• 4: GitHub issue 2243 in actions/checkout (link omitted to avoid creating a cross-reference)
• 5: GitHub pull request 2226 in actions/checkout (link omitted to avoid creating a cross-reference)
• 6: https://github.com/actions/checkout
• 7: GitHub issue 2248 in actions/checkout (link omitted to avoid creating a cross-reference)

🌐 Web query:

site:github.blog OR site:docs.github.com GitHub Actions Node 20 deprecation forced Node 24 runtime warning removal September 23 2026 ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION

💡 Result:

<search_synthesis>
GitHub has officially deprecated Node 20 for GitHub Actions, and it is scheduled for complete removal from the runner environment on September 23, 2026 [1]. Key points regarding the transition and the use of the environment variable: 1. Node 20 Deprecation: Node 20 reached end-of-life (EOL) in April 2026 [1]. GitHub began migrating the platform to Node 24, with Node 24 becoming the default runtime version for actions starting June 16, 2026 [1]. 2. ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: Users who needed to continue using Node 20 after the June 16 default switch were instructed to set the environment variable ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true in their workflow or runner machine [1]. 3. Final Removal: The use of this environment variable and the support for Node 20 will expire on September 23, 2026, when GitHub upgrades the runner environment and removes Node 20 entirely [1]. After this date, actions relying on Node 20 will no longer function [1]. Maintainers are advised to update their actions to be compatible with Node 24 to avoid disruption [1].
</search_synthesis>

<source_evidence>

Citations:

• 1: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

🏁 Script executed:

#!/bin/bash
# Check which deployment images install the claude CLI.
fd -t f 'Dockerfile*' | xargs -r rg -n -i 'claude|npm i|native install'

Repository: Jita81/commit-replay-bench

Length of output: 1725

🏁 Script executed:

#!/bin/bash
set -eu
printf '%s\n' '--- deployment files ---'
fd -t f . deploy | sort
printf '%s\n' '--- image and Dockerfile references ---'
rg -n -i 'dockerfile|image:|build:|api|claude' deploy compose* docker-compose* 2>/dev/null | head -250
printf '%s\n' '--- operator and security references ---'
rg -n -i -C 3 'container image ships|claude.*binary|claude.*image|api image|Dockerfile.builder|builder image' docs/OPERATOR.md docs/SECURITY.md

Repository: Jita81/commit-replay-bench

Length of output: 25954

🏁 Script executed:

#!/bin/bash
set -eu
printf '%s\n' '--- API Dockerfile ---'
sed -n '1,115p' deploy/Dockerfile
printf '%s\n' '--- compose image build ---'
sed -n '15,35p' deploy/docker-compose.yml
printf '%s\n' '--- Helm image helper and default ---'
sed -n '1,25p' deploy/helm/crb/values.yaml
sed -n '1,45p' deploy/helm/crb/templates/_helpers.tpl

Repository: Jita81/commit-replay-bench

Length of output: 8585

    def _reserve_slot(self) -> None:
        """Take the deployment-wide slot or refuse; the holder is released on a terminal state."""
        self.sessions_dir.mkdir(parents=True, exist_ok=True)
        os.chmod(self.sessions_dir, 0o700)
        lock = self.sessions_dir / "active.lock"
        try:
            fd = os.open(lock, os.O_WRONLY | os.O_CREAT | os.O_EXCL, 0o600)
        except FileExistsError:
            active = self.active()
            if active is not None:
                raise LoginError(
                    "login_in_progress",
                    f"a login session ({active.id[:8]}) is {active.state}; finish or cancel it first",
                ) from None
            lock.unlink(missing_ok=True)  # a stale holder: no non-terminal session remains
            return self._reserve_slot()
        os.close(fd)

Call _reserve_slot() in place of the active() check, and remove active.lock in cancel() and whenever state() observes a terminal state.

🏁 Script executed:

sed -n '130,330p' src/crb/server/claude_login.py
sed -n '90,218p' src/crb/server/claude_login_driver.py
rg -n 'start_new_session|setsid|pid.json|pid_file|supported.*host|/proc' src docs deploy tests/test_server_claude_login.py

Repository: Jita81/commit-replay-bench

Length of output: 14676

🤖 get_repo_knowledge executed:

get_repo_knowledge Jita81/commit-replay-bench /tmp/coderabbit-repo-knowledge/jita81-commit-replay-bench-137d90d9/conventions

Length of output: 4188

🏁 Script executed:

#!/bin/bash
set -eu
printf '%s\n' '--- project/runtime declarations ---'
for f in pyproject.toml setup.cfg setup.py Dockerfile deploy/Dockerfile deploy/Dockerfile.builder README.md docs/API.md docs/OPERATOR.md; do
  if [ -f "$f" ]; then
    echo "### $f"
    rg -n -i 'python|linux|darwin|macos|windows|support|supported|container|claude|login|proc|uvicorn' "$f" | head -80 || true
  fi
done
printf '%s\n' '--- login symbols and tests ---'
rg -n -C 3 'LoginBroker|cancel\\(|expires_at|STATE_EXPIRED|start_new_session|killpg|pty\\.fork|SIGKILL|SIGTERM|pid' src tests docs deploy -g '*.py' -g '*.md' -g 'Dockerfile*' | head -260
printf '%s\n' '--- exact stdlib references in local docs/source ---'
rg -n -C 4 'start_new_session|setsid|killpg|getpgid|pty\\.fork|process group|session leader' src tests docs -g '*.py' -g '*.md' | head -220

Repository: Jita81/commit-replay-bench

Length of output: 40152

🏁 Script executed:

#!/bin/bash
# Locate the UI type for the settings/builder response and any docs mention of claude_binary.
fd --iglob 'types.ts' ui/src | xargs -r rg -n -C4 'builder|Settings'
rg -n 'claude_binary|CLAUDE_BINARY' docs ui || echo "no mention in docs/ or ui/"

Repository: Jita81/commit-replay-bench

Length of output: 1253

🏁 Script executed:

#!/bin/bash
printf '%s\n' '--- settings implementation ---'
sed -n '130,205p' src/crb/server/settings.py
printf '%s\n' '--- /settings bindings ---'
rg -n -C5 'redacted\(\)|/settings|BuilderSettings|builder' src/crb/server
printf '%s\n' '--- API documentation ---'
sed -n '135,160p' docs/API.md
printf '%s\n' '--- UI types ---'
rg -n -C8 'interface .*Settings|type .*Settings|Builder|builder|Settings' ui/src --glob 'types.ts'
printf '%s\n' '--- claude_binary references ---'
rg -n 'claude_binary|CLAUDE_BINARY' docs ui src/crb/server

Repository: Jita81/commit-replay-bench

Length of output: 50383

🏁 Script executed:

#!/bin/bash
printf '%s\n' '--- docs/API.md settings section ---'
rg -n -C12 '^## .*Admin|GET /settings|/settings' docs/API.md
printf '%s\n' '--- ui/src/api/types.ts settings definitions ---'
rg -n -C15 'export (interface|type) .*Settings|interface .*Settings|type .*Settings|builder|raw' ui/src/api/types.ts
printf '%s\n' '--- relevant references ---'
rg -n 'claude_binary' docs/API.md ui/src/api/types.ts || true

Repository: Jita81/commit-replay-bench

Length of output: 20606

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

🌐 Web query:

Does window.open return null when the noopener feature is specified?

💡 Result:

<search_synthesis>
Yes, when the noopener feature is specified in window.open, the method typically returns null instead of a reference to the new window [1][2]. By design, including noopener in the window features parameter instructs the browser not to set the window.opener property on the newly opened window [1][3]. Because the opening window loses its reference to the new browsing context, window.open returns null, effectively preventing the opener from interacting with the new window [1][4]. Note that this behavior creates a limitation: it is not possible to use the return value of window.open to check if a popup was successfully opened or blocked by the browser when noopener is used, as the function returns null in both successful and blocked scenarios [4]. Additionally, there are ongoing efforts to refine this behavior in the HTML specification for cases where existing browsing contexts are reused (e.g., targets like _self, _top, or _parent), where returning null may be considered unintended [5]. However, for standard popup creation, you should expect null [1][2].
</search_synthesis>

<source_evidence>

Citations:

• 1: https://developer.mozilla.org/en-US/docs/Web/API/Window/open
• 2: https://github.com/mdn/content/blob/main/files/en-us/web/api/window/open/index.md
• 3: https://developer.mozilla.org/en-US/docs/Web/API/Window/opener
• 4: https://stackoverflow.com/questions/79776082/how-can-i-detect-if-a-browser-is-blocking-a-new-tab-or-popup-when-using-window
• 5: GitHub pull request 12845 in whatwg/html (link omitted to avoid creating a cross-reference)

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

🏁 Script executed:

sed -n '35,80p' src/crb/server/claude_login_driver.py
sed -n '125,190p' src/crb/server/claude_login_driver.py
rg -n 'def validate_claude_code_token|validate_claude_code_token|TOKEN_RE|FAILURE_HINTS' src/crb/server tests/test_server_claude_login.py
sed -n '205,242p' tests/test_server_claude_login.py

Repository: Jita81/commit-replay-bench

Length of output: 7725

🏁 Script executed:

sed -n '88,118p' src/crb/server/secrets.py
sed -n '88,210p' src/crb/server/claude_login_driver.py
rg -n 'FAKE_CLAUDE|Invalid authorization|TOKEN =|def _wait' tests/test_server_claude_login.py
sed -n '1,95p' tests/test_server_claude_login.py

Repository: Jita81/commit-replay-bench

Length of output: 11365

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

🏁 Script executed:

sed -n '100,240p' ui/src/screens/Settings/ClaudeCodeLoginCard.tsx
sed -n '110,180p' ui/src/screens/Settings/claudeCodeLogin.ts
rg -n '"`@tanstack/react-query`"|refetchInterval' ui/package.json ui/package-lock.json ui/pnpm-lock.yaml ui/src 2>/dev/null

Repository: Jita81/commit-replay-bench

Length of output: 10414

🏁 Script executed:

set -u
printf '%s\n' '--- package resolution ---'
sed -n '1,45p' ui/package.json
sed -n '1,35p' ui/package-lock.json
printf '%s\n' '--- available TanStack package files ---'
if [ -d ui/node_modules/@tanstack/query-core ]; then
  find ui/node_modules/@tanstack/query-core -maxdepth 3 -type f | sort | head -80
else
  echo 'ui/node_modules/@tanstack/query-core is unavailable'
fi
printf '%s\n' '--- relevant source references ---'
if [ -d ui/node_modules/@tanstack/query-core ]; then
  rg -n -C 8 'updateRefetchInterval|refetchInterval|isServer' ui/node_modules/@tanstack/query-core/src ui/node_modules/@tanstack/query-core/build 2>/dev/null | head -240
else
  echo 'TanStack Query source is unavailable in the checkout'
fi

Repository: Jita81/commit-replay-bench

Length of output: 2600

🌐 Web query:

TanStack Query v5.97.0 QueryObserver refetchInterval error state source updateRefetchInterval

💡 Result:

<search_synthesis>
In TanStack Query v5.97.0, the polling mechanism managed by QueryObserver continues to function regardless of whether the query is in an error state [1][2]. The refetchInterval feature operates on a dedicated timer that triggers fetches independently of the query&#39;s current status or data freshness [1][2]. Regarding your query about updateRefetchInterval: 1. Internal Implementation: QueryObserver uses a private method named #updateRefetchInterval (or updateRefetchInterval in older versions) to manage the polling timer [3][4][5][6]. This method is responsible for clearing any existing interval and scheduling a new one based on the current interval configuration [3][4]. It is called internally by the QueryObserver when dependencies change (such as query options or enabled state) [3][4][6]. 2. Error State Behavior: TanStack Query does not automatically stop polling when a request fails [1][2]. If you wish to stop polling when an error occurs, or adjust the interval based on the error state, you must provide a function to the refetchInterval option [1][2]. This function receives the Query object, allowing you to inspect the query state (including query.state.error) and return false to disable polling or return a new interval duration [1][2]. Example of conditional polling based on error state: useQuery({ queryKey: [&#39;data&#39;], queryFn: fetchData, refetchInterval: (query) => { // Stop polling if the query has an error if (query.state.error) return false; return 5000; // Poll every 5 seconds }, }) If you attempt to use updateRefetchInterval manually, please note that it is a private method intended for internal library use and should not be relied upon in application code [3][4][6]. Relying on internal methods can break when updating to future versions [3][4]. Always control polling behavior via the declarative refetchInterval option [1][2].
</search_synthesis>

<source_evidence>

Citations:

• 1: https://tanstack.com/query/latest/docs/framework/react/guides/polling
• 2: https://tanstack.com/query/v5/docs/framework/react/guides/polling
• 3: https://github.com/TanStack/query/blob/main/packages/query-core/src/queryObserver.ts
• 4: https://github.com/TanStack/query/blob/7f27e253ce1d14d15685d8d74e68e78a86013c20/packages/query-core/src/queryObserver.ts
• 5: GitHub discussion 4018 in TanStack/query (link omitted to avoid creating a cross-reference)
• 6: https://github.com/TanStack/query/blob/d4fd9417/packages/query-core/src/queryObserver.ts

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

🏁 Script executed:

#!/bin/bash
set -e
printf '%s\n' '--- candidate files ---'
git ls-files | rg '(^|/)(test_server_claude_login\.py|.*login.*\.py|.*broker.*\.py)$'
printf '%s\n' '--- LoginBroker references ---'
rg -n -C 5 'class LoginBroker|def start\(|STATE_AWAITING_CODE|STATE_EXPIRED|cli_failed|_wait\(' tests src . --glob '*.py' --glob '!/.git/**' | head -n 240
printf '%s\n' '--- target test ---'
sed -n '160,235p' tests/test_server_claude_login.py

Repository: Jita81/commit-replay-bench

Length of output: 22181