Visitar URL original
fix(cli): validate deploy input and show config errors by tkkhq · Pull Request #220 · Kong/volcano-cli · GitHub
Skip to content

fix(cli): validate deploy input and show config errors - #220

Open
tkkhq wants to merge 7 commits into
mainfrom
tkkhq/vol-1005-1009-cli
Open

fix(cli): validate deploy input and show config errors#220
tkkhq wants to merge 7 commits into
mainfrom
tkkhq/vol-1005-1009-cli

Conversation

@tkkhq

@tkkhq tkkhq commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tracking

Why

  • variables deploy accepted unsupported positional values, ignored them, and could deploy stale values from the environment file
  • config validation failures returned a generic HTTP 400 without the invalid field or constraint

Summary

  • reject unsupported positional values before reading files or sending a deploy request
  • render safe structured config validation details from the generated API client
  • keep the generic error fallback when structured details are absent

Verification

  • go test ./internal/api ./internal/cmd/config ./internal/cmd/variables ./internal/cmd/root -count=1
  • GOCACHE=/tmp/volcano-cli-220-go-build GOLANGCI_LINT_CACHE=/tmp/volcano-cli-220-golangci-cache make check
  • GOCACHE=/tmp/volcano-cli-220-go-build go build ./...
  • git diff --check origin/main...HEAD
  • exact-head CI passes check / check, CodeQL, and CLA; check / localmode-e2e has the same durable-runtime failure on current main

@tkkhq
tkkhq marked this pull request as ready for review September 20, 2026 23:12
@tkkhq
tkkhq requested a review from a team as a code owner September 20, 2026 23:12
Copilot AI balanced review requested due to automatic review settings September 20, 2026 23:12
Copilot AI reviewed Sep 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@tkkhq
tkkhq marked this pull request as draft September 20, 2026 23:17
@tkkhq
tkkhq force-pushed the tkkhq/vol-1005-1009-cli branch from 8d7803c to ee8446e Compare September 22, 2026 23:11
@tkkhq
tkkhq marked this pull request as ready for review September 23, 2026 15:49
@tkkhq

tkkhq commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex Review deploy validation and config error propagation. Focus on local/cloud parity, compatibility, and clear failures.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T16:35:43.572139Z ee8446e Manual request
🔒 Security Review ✅ Completed 2026-09-23T16:36:34.190270Z ee8446e Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Sep 23, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee8446ecdb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/api/errors.go Resolved
Comment thread internal/cmd/variables/variables.go Resolved
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: ee8446ecdb

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tkkhq