Repository navigation
Conversation
AI review: no P0-P2 findingsRelabels the browser sign-in user code as a "One-time sign-in code (not a secret)", adds a note when Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.
Human review: not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking
Why
Code: ABCD-EFGHwith no label. A coding agent reading that output can take an unlabelled token for an API key and stop (VOL-1535).volcano connect --signupsilently used the global git email for signup. A signed-out user saw their address appear with no explanation (VOL-1652).Summary
One-time sign-in code (not a secret): ABCD-EFGHinstead ofCode: ABCD-EFGH. This is the OAuth user code the approval page shows, not the device code or a token.connect --signuptakes the address fromgit config --global user.email(no--email), it prints a note: "The signup link includes , yourgit config --global user.email. You can sign up with any address on the signup page." No note when--emailis given. The address shows up in the printed signup link, which is where the user sees it.--json, so JSON stdout is unchanged. The--jsonresult shape is unchanged.docs/connect.mddescribes the labelled code, how it differs from the dashboard prompt's--device-code(which is a secret), and the git-email note.emailparameter today).--device-code(VOL-1535's web part, another PR).Verification
make check(openapi-generated-check, release-workflow-check,golangci-lint0 issues,make testall packages ok)go build ./...,make build FIRST_PARTY_DEVICE_CLIENT_ID=volcano-cli,./volcano --versionscripts/lint-docs.mjs docs): OKTestConnectSignupSaysTheEmailCameFromGit(text and--json: note on the log stream only);TestConnectSignupUsesEmailFlagOverARelayGitEmailnow asserts no note with--email;auth_testasserts the new label.nextandref, not theemailthe CLI sends, so the note does not claim the page prefills it or that the account uses it.