Visitar URL original
MDEV-31530 Localizations for Swahili language by lottaquestions · Pull Request #2676 · MariaDB/server · GitHub
Skip to content

MDEV-31530 Localizations for Swahili language - #2676

Merged
grooverdan merged 1 commit into
MariaDB:11.1from
lottaquestions:swahili-localization
Jul 4, 2023
Merged

grooverdan merged 1 commit into
MariaDB:11.1from
lottaquestions:swahili-localization

Conversation

@lottaquestions

Copy link
Copy Markdown
Contributor
  • The Jira issue number for this PR is: MDEV-31530

Description

Kenyan Swahili is enabled for error messages as well as datetime.

How can this PR be tested?

The following MTR tests have been updated to test for Swahili and have all passed successfully:

  • locale.test
  • locales.test
  • lc_time_names_basic.test
  • variables.test

Basing the PR against the correct MariaDB version

  • This is a new feature and the PR is based against the latest MariaDB development branch.
  • This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

Copyright

All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.

@CLAassistant

CLAassistant commented Jun 22, 2023 •

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@grooverdan

grooverdan commented Jun 22, 2023 •

Copy link
Copy Markdown
Member

Looks very good.

Reviewed against https://icu4c-demos.unicode.org/icu-bin/locexp?d_=en&_=sw_KE for the locales.

The abbreviated day names are different from the standard. Do you have reference where the "J3","J4","J5","Al","Ij","J1","J2" comes from?

Can you put the MDEV into the title of the commit message too please?

@lottaquestions
lottaquestions force-pushed the swahili-localization branch 2 times, most recently from 6a6c10e to ae4a191 Compare June 23, 2023 15:41
@lottaquestions

lottaquestions commented Jun 23, 2023 •

Copy link
Copy Markdown
Contributor Author

Looks very good.

Reviewed against https://icu4c-demos.unicode.org/icu-bin/locexp?d_=en&_=sw_KE for the locales.

The abbreviated day names are different from the standard. Do you have reference where the "J3","J4","J5","Al","Ij","J1","J2" comes from?

@grooverdan I checked with other native speakers, it looks like the short names that I used are not official. I have updated the PR to use the official short names, which are basically the long names.

Can you put the MDEV into the title of the commit message too please?

MDEV added to the commit message as requested.

Kenyan Swahili is enabled for error messages as well as datetime.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services, Inc.
@grooverdan
grooverdan force-pushed the swahili-localization branch from 0ced0b4 to 4a1bfad Compare July 4, 2023 00:41
@grooverdan
grooverdan merged commit c054a62 into MariaDB:11.1 Jul 4, 2023
@grooverdan

Copy link
Copy Markdown
Member

Thank you very much @lottaquestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants