Visitar URL original
Lock for all Ref.Emit code when on mono by AArnott · Pull Request #1035 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

Lock for all Ref.Emit code when on mono - #1035

Merged
AArnott merged 1 commit into
MessagePack-CSharp:masterfrom
AArnott:parallelOnMono
Sep 12, 2020
Merged

AArnott merged 1 commit into
MessagePack-CSharp:masterfrom
AArnott:parallelOnMono

Conversation

@AArnott

@AArnott AArnott commented Sep 11, 2020

Copy link
Copy Markdown
Collaborator

This allows us to resume running tests concurrently on mono.
I also remove a smaller lock that was there even for .NET Framework, since I don't know why we would need that and it simplified things slightly to remove it.

Workaround for mono/mono#20369

This allows us to resume running tests concurrently on mono.
I also remove a smaller lock that was there even for .NET Framework, since I don't know why we would need that and it simplified things slightly to remove it.
@AArnott AArnott added this to the v2.1 milestone Sep 11, 2020
@AArnott
AArnott requested a review from neuecc September 11, 2020 22:45
@AArnott AArnott self-assigned this Sep 11, 2020

@neuecc neuecc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, all methods...
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants