Visitar URL original
Update Microsoft.NET.StringTools dependency to 17.4.0 by AArnott · Pull Request #1515 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

Update Microsoft.NET.StringTools dependency to 17.4.0 - #1515

Merged
AArnott merged 2 commits into
MessagePack-CSharp:masterfrom
AArnott:StringToolsUpdate
Nov 19, 2022
Merged

AArnott merged 2 commits into
MessagePack-CSharp:masterfrom
AArnott:StringToolsUpdate

Conversation

@AArnott

@AArnott AArnott commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@AArnott AArnott added this to the v2.4 milestone Oct 10, 2022
@AArnott

AArnott commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator Author

Blocked by dotnet/msbuild#8039

rainersigwald pushed a commit to dotnet/msbuild that referenced this pull request Oct 18, 2022
Fixes #8039

### Description

Microsoft.NET.StringTools currently contains a netstandard2.0 ref assembly but no matching implementation assembly. This causes a run-time bind failure when the library is used by a 3.1 app, for example.

### Customer Impact

The package is being picked up MessagePack which targets netstandard2.0. The issue [blocks it from updating to a newer version of the library](MessagePack-CSharp/MessagePack-CSharp#1515).

### Regression?

Yes, this regressed in 17.3.0. Only the initial version of the package was correct.

### Risk

Low.

### Testing

Built the package locally and inspected its contents.

### Notes

This pull request uses a [documented workaround](https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#advanced-extension-points-to-create-customized-package).

Package contents without the fix:
```
/lib
    net35
    net472
    net7.0
/ref
    net35
    net472
    net7.0
    netstandard2.0
```

Package contents with the fix:
```
/lib
    net35
    net472
    net7.0
    netstandard2.0
/ref
    net35
    net472
    net7.0
    netstandard2.0
```

@AArnott AArnott left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to 17.4.0 to fix break

@AArnott
AArnott merged commit 45ff089 into MessagePack-CSharp:master Nov 19, 2022
@AArnott
AArnott deleted the StringToolsUpdate branch November 19, 2022 15:34
@AArnott AArnott changed the title Update Microsoft.NET.StringTools dependency to 17.3.1 Update Microsoft.NET.StringTools dependency to 17.4.0 Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant